Skip to content
Snippets Groups Projects
Unverified Commit a745bb7e authored by github-automation-metabase's avatar github-automation-metabase Committed by GitHub
Browse files

Don't disable triggers before data perms migration (#46826) (#46831)


I didn't consider that we might not have permissions necessary to
disable triggers.

Co-authored-by: default avatarJohn Swanson <john.swanson@metabase.com>
parent acca6b9b
No related branches found
No related tags found
No related merge requests found
ALTER TABLE data_permissions DISABLE TRIGGER ALL;
-- Insert DB-level permissions for cases where no table-level perms are set
INSERT INTO data_permissions (group_id, perm_type, db_id, schema_name, table_id, perm_value)
......@@ -114,5 +113,3 @@ WHERE NOT EXISTS (
AND dp.perm_type = 'perms/data-access'
)
AND pg.name != 'Administrators';
ALTER TABLE data_permissions ENABLE TRIGGER ALL;
-- Insert DB-level permissions with a check for table-level permissions
ALTER TABLE data_permissions DISABLE TRIGGER ALL;
INSERT INTO data_permissions (group_id, perm_type, db_id, schema_name, table_id, perm_value)
SELECT pg.id AS group_id,
'perms/download-results' AS perm_type,
......@@ -120,5 +118,3 @@ WHERE NOT EXISTS (
AND dp.perm_type = 'perms/download-results'
)
AND pg.name != 'Administrators';
ALTER TABLE data_permissions ENABLE TRIGGER ALL;
-- Insert DB-level permissions with a check for table-level permissions
ALTER TABLE data_permissions DISABLE TRIGGER ALL;
INSERT INTO data_permissions (group_id, perm_type, db_id, schema_name, table_id, perm_value)
SELECT pg.id AS group_id,
'perms/manage-table-metadata' AS perm_type,
......@@ -98,5 +96,3 @@ WHERE NOT EXISTS (
AND dp.perm_type = 'perms/manage-table-metadata'
)
AND pg.name != 'Administrators';
ALTER TABLE data_permissions ENABLE TRIGGER ALL;
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment