-
- Downloads
Switch native query execution to use Statement instead of PreparedStatement (#14883)
Switch query execution to use `Statement` instead of `PreparedStatement` when there are no params Add new multimethod to create a `Statement`, rather than `PreparedStatement`, which works similarly, called `statement` Add new multimethod to run a SQL query against a Statement, similar to `execute-query!`, called `execute-statement!` For consistency, rename `execute-query!` to `execute-prepared-statement!` Change `execute-reducible-query` to capture whether the query has params, and if not, using the new multimethods instead Update fetch-results-metadata-test so it replaces execute-select! instead of prepared-statement Adding `statement-supported?` multimethod (defaults to true), to let drivers control whether statements are used at all Updating Oracle driver to not override holdability for `statement`, similar to `prepared-statement`, and bumping module version Updating SparkSQL driver to indicate that statements are not supported, and bumping module version Fixing Redshift test to also override `execute-statement!` so it can capture the SQL for a statement
Showing
- dev/src/dev.clj 1 addition, 1 deletiondev/src/dev.clj
- enterprise/backend/src/metabase_enterprise/audit/pages/common.clj 1 addition, 1 deletion...se/backend/src/metabase_enterprise/audit/pages/common.clj
- modules/drivers/oracle/project.clj 1 addition, 1 deletionmodules/drivers/oracle/project.clj
- modules/drivers/oracle/src/metabase/driver/oracle.clj 16 additions, 0 deletionsmodules/drivers/oracle/src/metabase/driver/oracle.clj
- modules/drivers/redshift/test/metabase/driver/redshift_test.clj 3 additions, 0 deletions...s/drivers/redshift/test/metabase/driver/redshift_test.clj
- modules/drivers/sparksql/project.clj 1 addition, 1 deletionmodules/drivers/sparksql/project.clj
- modules/drivers/sparksql/src/metabase/driver/sparksql.clj 3 additions, 0 deletionsmodules/drivers/sparksql/src/metabase/driver/sparksql.clj
- modules/drivers/sqlserver/test/metabase/driver/sqlserver_test.clj 2 additions, 2 deletions...drivers/sqlserver/test/metabase/driver/sqlserver_test.clj
- src/metabase/driver/sql_jdbc/execute.clj 86 additions, 9 deletionssrc/metabase/driver/sql_jdbc/execute.clj
- test/metabase/api/card_test.clj 5 additions, 5 deletionstest/metabase/api/card_test.clj
- test/metabase/driver/postgres_test.clj 24 additions, 1 deletiontest/metabase/driver/postgres_test.clj
Loading
Please register or sign in to comment