Skip to content

GitLab

Explore

Sign in

Primary navigation

Project

M

Metabase
- Activity
- Members
- Labels
- Issues
- Issue boards
- Milestones
- Iterations
- Wiki
- Requirements
- Environments
- Terraform modules
- Incidents
- Service Desk

Snippets Groups Projects

aac751c2

Unverified Commit aac751c2 authored 10 months ago by Jesse Devaney Committed by GitHub 10 months ago

Downloads
- Patches
- Plain Diff

Fix tool-tip values not being scaled in waterfall charts (#44180)

* fix column scaling issues in waterfall chart

- refactor dataset scaling to behave like scatter and cartesian chart models

* add E2E test

parent 9a68f258

Branches

Tags

No related merge requests found

Changes 3

Hide whitespace changes

Inline Side-by-side

Showing

e2e/test/scenarios/visualizations-charts/waterfall.cy.spec.js 26 additions, 0 deletions

...test/scenarios/visualizations-charts/waterfall.cy.spec.js
frontend/src/metabase/visualizations/echarts/cartesian/waterfall/model/dataset.ts 5 additions, 12 deletions

...sualizations/echarts/cartesian/waterfall/model/dataset.ts
frontend/src/metabase/visualizations/echarts/cartesian/waterfall/model/index.ts 17 additions, 7 deletions

...visualizations/echarts/cartesian/waterfall/model/index.ts

with 48 additions and 19 deletions

Loading

0% Loading or .

You are about to add 0 people to the discussion. Proceed with caution.

Finish editing this message first!

Please register or sign in to comment