-
- Downloads
Consolidate action form logic (#29326)
* Make `ActionForm` accept an `action` prop * Make field settings inside `ActionForm` if missing * Clean date-time values inside `ActionForm` * WIP * Clean and filter values on submit in `ActionForm` * Sort `ActionVizForm` props * Sort `Action` props * Use more generic `WritebackAction` type * Move more logic into the `ActionForm` * Add `useActionForm` hook * Fix parameter type in tests * Fix submitting a form when all parameters mapped * Move utils to `useActionForm` * Fix submit button label in public action e2e tests * Filter changed values only for implicit update actions * Rename `cleanInitialValues` to `cleanedInitialValues` * Fix `shouldShowConfirmation` can be a string * Nice boring code * Fix types in tests * Small rename * Move `useActionForm` utils closer to source (#29328) * Fix `ActionForm` ignored submit errors * Fix default values display in the form editor * Fix names
Showing
- frontend/src/metabase/actions/components/ActionForm/ActionForm.tsx 48 additions, 35 deletions...src/metabase/actions/components/ActionForm/ActionForm.tsx
- frontend/src/metabase/actions/components/ActionForm/ActionForm.unit.spec.tsx 79 additions, 31 deletions...se/actions/components/ActionForm/ActionForm.unit.spec.tsx
- frontend/src/metabase/actions/components/ActionViz/Action.tsx 24 additions, 27 deletions...tend/src/metabase/actions/components/ActionViz/Action.tsx
- frontend/src/metabase/actions/components/ActionViz/Action.unit.spec.tsx 1 addition, 1 deletion...etabase/actions/components/ActionViz/Action.unit.spec.tsx
- frontend/src/metabase/actions/components/ActionViz/ActionVizForm.tsx 33 additions, 26 deletions...c/metabase/actions/components/ActionViz/ActionVizForm.tsx
- frontend/src/metabase/actions/components/ActionViz/utils.ts 12 additions, 1 deletionfrontend/src/metabase/actions/components/ActionViz/utils.ts
- frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormCreator.tsx 14 additions, 2 deletions...ions/containers/ActionCreator/FormCreator/FormCreator.tsx
- frontend/src/metabase/actions/containers/ActionCreator/FormCreator/FormCreator.unit.spec.tsx 24 additions, 0 deletions...iners/ActionCreator/FormCreator/FormCreator.unit.spec.tsx
- frontend/src/metabase/actions/containers/ActionParametersInputForm/ActionParametersInputForm.tsx 34 additions, 66 deletions...s/ActionParametersInputForm/ActionParametersInputForm.tsx
- frontend/src/metabase/actions/containers/ActionParametersInputForm/ActionParametersInputForm.unit.spec.tsx 46 additions, 32 deletions...rametersInputForm/ActionParametersInputForm.unit.spec.tsx
- frontend/src/metabase/actions/containers/ActionParametersInputForm/ActionParametersInputModal.tsx 9 additions, 4 deletions.../ActionParametersInputForm/ActionParametersInputModal.tsx
- frontend/src/metabase/actions/containers/ActionParametersInputForm/utils.ts 0 additions, 58 deletions...ase/actions/containers/ActionParametersInputForm/utils.ts
- frontend/src/metabase/actions/containers/ActionParametersInputForm/utils.unit.spec.ts 0 additions, 110 deletions...s/containers/ActionParametersInputForm/utils.unit.spec.ts
- frontend/src/metabase/actions/hooks/use-action-form/index.ts 1 addition, 0 deletionsfrontend/src/metabase/actions/hooks/use-action-form/index.ts
- frontend/src/metabase/actions/hooks/use-action-form/use-action-form.ts 76 additions, 0 deletions...metabase/actions/hooks/use-action-form/use-action-form.ts
- frontend/src/metabase/actions/hooks/use-action-form/utils.ts 157 additions, 0 deletionsfrontend/src/metabase/actions/hooks/use-action-form/utils.ts
- frontend/src/metabase/actions/hooks/use-action-form/utils.unit.spec.ts 441 additions, 0 deletions...metabase/actions/hooks/use-action-form/utils.unit.spec.ts
- frontend/src/metabase/actions/utils.ts 0 additions, 103 deletionsfrontend/src/metabase/actions/utils.ts
- frontend/src/metabase/actions/utils.unit.spec.ts 0 additions, 361 deletionsfrontend/src/metabase/actions/utils.unit.spec.ts
- frontend/src/metabase/public/containers/PublicAction/PublicAction.tsx 5 additions, 26 deletions.../metabase/public/containers/PublicAction/PublicAction.tsx
Loading
Please register or sign in to comment