Skip to content
Snippets Groups Projects
Unverified Commit abcfd22a authored by Kyle Doherty's avatar Kyle Doherty Committed by GitHub
Browse files

Fullscreen dash header fixes (#8586)

* hide badge when fullscreen

* hide move if fullscreen

* fix title color in night mode
parent 0b58d20e
No related branches found
No related tags found
No related merge requests found
......@@ -159,7 +159,7 @@ export default class Header extends Component {
<div className="Entity py3">
<span className="inline-block mb1">{titleAndDescription}</span>
{attribution}
{!this.props.isEditingInfo && (
{this.props.showBadge && (
<CollectionBadge
collectionId={item.collection_id}
analyticsContext={this.props.analyticsContext}
......
......@@ -51,6 +51,10 @@
background-color: var(--color-bg-black);
}
.Dashboard.Dashboard--night .DashboardHeader {
color: var(--color-text-white);
}
.Dashboard.Dashboard--night .Card {
color: var(--color-text-white);
}
......
......@@ -297,16 +297,18 @@ export default class DashboardHeader extends Component {
);
}
buttons.push(
<Tooltip tooltip={t`Move dashboard`}>
<Link
to={location.pathname + "/move"}
data-metabase-event={"Dashboard;Move"}
>
<Icon className="text-brand-hover" name="move" size={18} />
</Link>
</Tooltip>,
);
if (!isFullscreen) {
buttons.push(
<Tooltip tooltip={t`Move dashboard`}>
<Link
to={location.pathname + "/move"}
data-metabase-event={"Dashboard;Move"}
>
<Icon className="text-brand-hover" name="move" size={18} />
</Link>
</Tooltip>,
);
}
if (!isFullscreen && !isEditing && canEdit) {
buttons.push(
......@@ -347,6 +349,7 @@ export default class DashboardHeader extends Component {
analyticsContext="Dashboard"
item={dashboard}
isEditing={this.props.isEditing}
showBadge={!this.props.isEditing && !this.props.isFullscreen}
isEditingInfo={this.props.isEditing}
headerButtons={this.getHeaderButtons()}
editingTitle={t`You are editing a dashboard`}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment