Merge pull request #208 from metabase/handle_postgres_objects_json_serialization

Handle postgres objects json serialization

src/metabase/middleware/format.clj

 (ns metabase.middleware.format
   (:require [clojure.core.match :refer [match]]
-            cheshire.factory
+            (cheshire factory
+                      [generate :refer [add-encoder encode-str]])
             [medley.core :refer [filter-vals map-vals]]
             [metabase.util :as util]))
 
 (declare -format-response)
 
-;; # SHADY HACK
+;; ## SHADY HACK
 ;; Tell the JSON middleware to use a date format that includes milliseconds
 (intern 'cheshire.factory 'default-date-format "yyyy-MM-dd'T'HH:mm:ss.SSS'Z'")
 
-;; # FORMAT RESPONSE MIDDLEWARE
+
+;; ## Custom JSON encoders
+
+(add-encoder org.h2.jdbc.JdbcClob (fn [clob ^com.fasterxml.jackson.core.JsonGenerator json-generator]  ; stringify JDBC Clobs
+                                    (.writeString json-generator (util/jdbc-clob->str clob))))
+(add-encoder org.postgresql.util.PGobject encode-str)                                                 ; stringify Postgres binary objects (e.g. PostGIS geometries)
+
+
+;; ## FORMAT RESPONSE MIDDLEWARE
 (defn format-response
   "Middleware that recurses over Clojure object before it gets converted to JSON and makes adjustments neccessary so the formatter doesn't barf.
    e.g. functions and delays are stripped and H2 Clobs are converted to strings."
@@ -25,13 +34,9 @@
                          (fn? %)))
                m))
 
-(defn- clob? [obj]
-  (= (type obj) org.h2.jdbc.JdbcClob))
-
 (defn- -format-response [obj]
   (cond
     (map? obj)  (->> (remove-fns-and-delays obj)   ; recurse over all vals in the map
                      (map-vals -format-response))
     (coll? obj) (map -format-response obj)        ; recurse over all items in the collection
-    (clob? obj) (util/jdbc-clob->str obj)
     :else       obj))

src/metabase/util.clj

@@ -107,11 +107,11 @@
 
 (defn jdbc-clob->str
   "Convert a `JdbcClob` to a `String`."
-  ([clob]
+  (^String
+   [clob]
    (when clob
      (if (string? clob) clob
-         (->> (-> (.getCharacterStream ^org.h2.jdbc.JdbcClob clob)
-                  (jdbc-clob->str []))
+         (->> (jdbc-clob->str (.getCharacterStream ^org.h2.jdbc.JdbcClob clob) [])
               (interpose "\n")
               (apply str)))))
   ([^java.io.BufferedReader reader acc]