Authority Level on collections (formerly Typed collections) (#16191)
* Add type on collection * Search with collection type * Cleanup bounded heap accumulator * Make search conditionally bump official collection items * collection api and tests * Put collection type onto hydrated cards on dashboards * Move official collection type scoring into ee codebase * ensure ee and oss agree when not official collection * Mark Collections tree with type * Remove unnecessary `and`s when no check for enhancements * Tests for setting collection tree type * Include hydration for collection type on dashboards * Make sure created test collections are cleaned up * Cleanup tests, don't search on collection_type looks for all text fields and searches the term against that. official would bring back all official types. no bueno * Docstring on protocol and don't shadow comparator * update to new ee impl var passing style * Collection model ensures no type change on personal collection * Check for personal collection when updating type model checks for personal collection and rejects in the update but doesn't check for children of personal collection. * Update checking for unchangeable properties of a personal collection * Cleanup: type collection tree, batched hydration, combine error checks * Cleanup * move bounded-heap accumulator to utils * switch to test.check testing * Bad test just to see what our CI will report * remove purposeful failing test (was for CI) * collection.type -> collection.authority_level * Test the actual ee scoring impl, not the wrapped one locally i had enhancements enabled so the tests were passing, but in CI it was failing as it did not have enhancements enabled
Showing
- .dir-locals.el 1 addition, 0 deletions.dir-locals.el
- enterprise/backend/src/metabase_enterprise/search/scoring.clj 26 additions, 0 deletions...rprise/backend/src/metabase_enterprise/search/scoring.clj
- enterprise/backend/test/metabase_enterprise/search/scoring_test.clj 23 additions, 0 deletions.../backend/test/metabase_enterprise/search/scoring_test.clj
- resources/migrations/000_migrations.yaml 14 additions, 0 deletionsresources/migrations/000_migrations.yaml
- src/metabase/api/collection.clj 33 additions, 13 deletionssrc/metabase/api/collection.clj
- src/metabase/api/dashboard.clj 1 addition, 1 deletionsrc/metabase/api/dashboard.clj
- src/metabase/api/search.clj 3 additions, 1 deletionsrc/metabase/api/search.clj
- src/metabase/models/collection.clj 21 additions, 25 deletionssrc/metabase/models/collection.clj
- src/metabase/models/dashboard.clj 17 additions, 5 deletionssrc/metabase/models/dashboard.clj
- src/metabase/search/config.clj 8 additions, 3 deletionssrc/metabase/search/config.clj
- src/metabase/search/scoring.clj 52 additions, 49 deletionssrc/metabase/search/scoring.clj
- src/metabase/util.clj 31 additions, 1 deletionsrc/metabase/util.clj
- test/metabase/api/collection_test.clj 75 additions, 3 deletionstest/metabase/api/collection_test.clj
- test/metabase/api/dashboard_test.clj 20 additions, 1 deletiontest/metabase/api/dashboard_test.clj
- test/metabase/api/search_test.clj 25 additions, 21 deletionstest/metabase/api/search_test.clj
- test/metabase/models/collection_test.clj 8 additions, 0 deletionstest/metabase/models/collection_test.clj
- test/metabase/search/scoring_test.clj 1 addition, 1 deletiontest/metabase/search/scoring_test.clj
- test/metabase/util_test.clj 36 additions, 0 deletionstest/metabase/util_test.clj
Loading
Please register or sign in to comment