Skip to content
Snippets Groups Projects
Unverified Commit ad80924b authored by Nick Fitzpatrick's avatar Nick Fitzpatrick Committed by GitHub
Browse files

Check for errors when transforming series (#21825)

parent f810e2fa
Branches
Tags
No related merge requests found
......@@ -58,7 +58,7 @@ export function getVisualizationRaw(series) {
export function getVisualizationTransformed(series) {
// don't transform if we don't have the data
if (_.any(series, s => s.data == null)) {
if (_.any(series, s => s.data == null) || _.any(series, s => s.error)) {
return getVisualizationRaw(series);
}
......
......@@ -17,7 +17,7 @@ const Q2 = {
display: "scalar",
};
describe.skip("issue 21665", () => {
describe("issue 21665", () => {
beforeEach(() => {
restore();
cy.signInAsAdmin();
......@@ -59,18 +59,10 @@ describe.skip("issue 21665", () => {
visitDashboard(id);
});
/**
* WARNING!
* Until this issue gets resolved, you will have to manually stop this test EVEN AFTER IT FAILS!
* It will send your browser in the infinite loop and can eventually freeze your browser or even the whole system if left unattended.
*
* TODO:
* Once this issue gets fixed, please remove the arbitrary wait and replace it with the positive assertion.
*/
cy.wait(1000);
cy.get("@dashboardLoaded").should("have.been.calledThrice");
cy.findByText("There was a problem displaying this chart.").should(
"be.visible",
);
});
});
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment