Skip to content
Snippets Groups Projects
Unverified Commit adc985e0 authored by Howon Lee's avatar Howon Lee Committed by GitHub
Browse files

Audit cache controls (#18001)

We added cache control fields for dashboard and database and actually use it for cards: presumably EE folks want to audit that stuff. Here is the addition of those fields to the table views.
parent fa86e491
Branches
Tags
No related merge requests found
......@@ -13,6 +13,7 @@
[:saved_by_id {:display_name "Saved by User ID", :base_type :type/Text, :remapped_to :saved_by}]
[:saved_by {:display_name "Saved by", :base_type :type/Text, :remapped_from :saved_by_id}]
[:saved_on {:display_name "Saved on", :base_type :type/DateTime}]
[:cache_ttl {:display_name "Cache Duration", :base_type :type/Integer}]
[:last_edited_on {:display_name "Last edited on", :base_type :type/DateTime}]
[:cards {:display_name "Cards", :base_type :type/Integer}]
[:public_link {:display_name "Public Link", :base_type :type/URL}]
......@@ -44,6 +45,7 @@
[:u.id :saved_by_id]
[(common/user-full-name :u) :saved_by]
[:d.created_at :saved_on]
[:d.cache_ttl :saved_on]
[:d.updated_at :last_edited_on]
[:cc.card_count :cards]
[(hsql/call :case
......
......@@ -36,7 +36,7 @@
[:table_id {:display_name "Table ID", :base_type :type/Integer, :remapped_to :table_name}]
[:table_name {:display_name "Table", :base_type :type/Text, :remapped_from :table_id}]
[:avg_running_time_ms {:display_name "Avg. exec. time (ms)", :base_type :type/Number}]
[:cache_ttl {:display_name "Cache TTL", :base_type :type/Number}]
[:cache_ttl {:display_name "Cache Duration", :base_type :type/Number}]
[:public_link {:display_name "Public Link", :base_type :type/URL}]
[:total_views {:display_name "Total Views", :base_type :type/Integer}]]
:results (common/reducible-query
......
......@@ -84,7 +84,8 @@
[:added_on {:display_name "Added On", :base_type :type/DateTime}]
[:sync_schedule {:display_name "Sync Schedule", :base_type :type/Text}]
[:schemas {:display_name "Schemas", :base_type :type/Integer}]
[:tables {:display_name "Tables", :base_type :type/Integer}]]
[:tables {:display_name "Tables", :base_type :type/Integer}]
[:cache_ttl {:display_name "Cache Duration", :base_type :type/Integer}]]
:results (common/reducible-query
(->
{:with [[:counts {:select [[:db_id :id]
......@@ -97,7 +98,8 @@
[:db.created_at :added_on]
[:db.metadata_sync_schedule :sync_schedule]
[:counts.schemas :schemas]
[:counts.tables :tables]]
[:counts.tables :tables]
[:db.cache_ttl :cache_ttl]]
:from [[:metabase_database :db]]
:left-join [:counts [:= :db.id :counts.id]]
:order-by [[:%lower.db.name :asc]
......
......@@ -214,7 +214,7 @@
[:table_id {:display_name "Table ID", :base_type :type/Integer, :remapped_to :table_name}]
[:table_name {:display_name "Table", :base_type :type/Text, :remapped_from :table_id}]
[:avg_running_time_ms {:display_name "Avg. exec. time (ms)", :base_type :type/Number}]
[:cache_ttl {:display_name "Cache TTL", :base_type :type/Number}]
[:cache_ttl {:display_name "Cache Duration", :base_type :type/Number}]
[:public_link {:display_name "Public Link", :base_type :type/URL}]
[:total_views {:display_name "Total Views", :base_type :type/Integer}]]
:results (common/reducible-query
......
......@@ -56,6 +56,7 @@ export const table = (searchString?: string) => ({
{ name: "average_execution_time_ms", enabled: true },
{ name: "cards", enabled: true },
{ name: "saved_by_id", enabled: true },
{ name: "cache_ttl", enabled: true },
{
name: "public_link",
enabled: true,
......
......@@ -69,6 +69,7 @@ export const table = (searchString?: string) => ({
{ name: "schemas", enabled: true },
{ name: "tables", enabled: true },
{ name: "sync_schedule", enabled: true },
{ name: "cache_ttl", enabled: true },
{ name: "added_on", enabled: true, date_format: "M/D/YYYY, h:mm A" },
],
},
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment