Skip to content
Snippets Groups Projects
Unverified Commit ae2c9609 authored by Aleksandr Lesnenko's avatar Aleksandr Lesnenko Committed by GitHub
Browse files

fix single series bar hover (#43984)

* fix single series bar hover

* prefer reduced motion
parent febfe4a5
No related branches found
No related tags found
No related merge requests found
......@@ -231,8 +231,10 @@ export const useChartEvents = (
? settings.series(seriesModel.legacySeriesSettingsObjectKey)
.display === "bar"
: false;
const shouldHighlightEntireSeries =
isBarSeries && chartModel.seriesModels.length > 1;
if (originalDatumIndex != null && !isBarSeries) {
if (originalDatumIndex != null && !shouldHighlightEntireSeries) {
// (issue #40215)
// since some transformed datasets have indexes differing from
// the original datasets indexes and ECharts uses the transformedDataset
......
import { useCallback, useMemo } from "react";
import { isCypressActive } from "metabase/env";
import { isReducedMotionPreferred } from "metabase/lib/dom";
import { extractRemappings } from "metabase/visualizations";
import { getChartMeasurements } from "metabase/visualizations/echarts/cartesian/chart-measurements";
import { getCartesianChartModel } from "metabase/visualizations/echarts/cartesian/model";
......@@ -115,7 +115,7 @@ export function useModelsAndOption({
return {};
}
const shouldAnimate = !isPlaceholder && !isCypressActive;
const shouldAnimate = !isPlaceholder && !isReducedMotionPreferred();
switch (card.display) {
case "waterfall":
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment