Stop a few unnecessary query reruns in Models (#25681)
* Fix/refactor QB dirty results selector * Don't clobber query results & last run card when canceling model changes * Always rerun updated questions if they have a dirty query * Add action that only reruns dirty question queries * Stop rerunning model queries in a few scenarios where they don't need to run * Fix e2e tests * Add e2e tests to ensure reruns when necessary
Showing
- frontend/src/metabase/query_builder/actions/core/core.js 4 additions, 1 deletionfrontend/src/metabase/query_builder/actions/core/core.js
- frontend/src/metabase/query_builder/actions/models.js 3 additions, 3 deletionsfrontend/src/metabase/query_builder/actions/models.js
- frontend/src/metabase/query_builder/actions/querying.js 14 additions, 0 deletionsfrontend/src/metabase/query_builder/actions/querying.js
- frontend/src/metabase/query_builder/components/DatasetEditor/DatasetEditor.jsx 1 addition, 1 deletion.../query_builder/components/DatasetEditor/DatasetEditor.jsx
- frontend/src/metabase/query_builder/reducers.js 0 additions, 2 deletionsfrontend/src/metabase/query_builder/reducers.js
- frontend/src/metabase/query_builder/selectors.js 35 additions, 21 deletionsfrontend/src/metabase/query_builder/selectors.js
- frontend/test/metabase/query_builder/selectors.unit.spec.js 1 addition, 1 deletionfrontend/test/metabase/query_builder/selectors.unit.spec.js
- frontend/test/metabase/scenarios/models/models-metadata.cy.spec.js 66 additions, 26 deletions...test/metabase/scenarios/models/models-metadata.cy.spec.js
- frontend/test/metabase/scenarios/models/models-query-editor.cy.spec.js 69 additions, 0 deletions.../metabase/scenarios/models/models-query-editor.cy.spec.js
- frontend/test/metabase/scenarios/models/reproductions/19180-native-model-results-disappear.cy.spec.js 0 additions, 1 deletion...oductions/19180-native-model-results-disappear.cy.spec.js
- frontend/test/metabase/scenarios/models/reproductions/22517-add-remove-column-drops-metadata.cy.spec.js 0 additions, 1 deletion...uctions/22517-add-remove-column-drops-metadata.cy.spec.js
Loading
Please register or sign in to comment