Merge pull request #1370 from metabase/metabase_on_mysql

Allow Metabase to use MySQL for the application db

resources/migrations/010_add_revision_table.yaml

@@ -61,3 +61,8 @@ databaseChangeLog:
             replace:
               replace: WITHOUT
               with: WITH
+        - modifySql:
+            dbms: mysql
+            replace:
+              replace: object VARCHAR
+              with: object TEXT

resources/migrations/013_add_activity_table.yaml

@@ -85,3 +85,8 @@ databaseChangeLog:
             replace:
               replace: WITHOUT
               with: WITH
+        - modifySql:
+            dbms: mysql
+            replace:
+              replace: details VARCHAR
+              with: details TEXT

src/metabase/db.clj

@@ -62,6 +62,12 @@
              (case (config/config-kw :mb-db-type)
                :h2       {:type     :h2
                           :db       @db-file}
+               :mysql    {:type     :mysql
+                          :host     (config/config-str :mb-db-host)
+                          :port     (config/config-int :mb-db-port)
+                          :dbname   (config/config-str :mb-db-dbname)
+                          :user     (config/config-str :mb-db-user)
+                          :password (config/config-str :mb-db-pass)}
                :postgres {:type     :postgres
                           :host     (config/config-str :mb-db-host)
                           :port     (config/config-int :mb-db-port)
@@ -75,6 +81,7 @@
            (case (:type details)
              :h2       (kdb/h2 (assoc details :naming {:keys   s/lower-case
                                                        :fields s/upper-case}))
+             :mysql    (kdb/mysql (assoc details :db (:dbname details)))
              :postgres (kdb/postgres (assoc details :db (:dbname details)))))))
 
 
@@ -311,7 +318,9 @@
                   (models/pre-insert entity)
                   (models/internal-pre-insert entity))
         {:keys [id]} (-> (k/insert entity (k/values vals))
-                         (set/rename-keys {(keyword "scope_identity()") :id}))]
+                         ;; this takes database specific keys returned from a jdbc insert and maps them to :id
+                         (set/rename-keys {(keyword "scope_identity()") :id
+                                           :generated_key               :id}))]
     (models/post-insert entity (entity id))))