Skip to content
Snippets Groups Projects
Unverified Commit afc53f40 authored by Dalton's avatar Dalton Committed by GitHub
Browse files

Collections changes feature branch (#19848)


* Add PinnedItemCard component (#19765)

* convert Card component to typescript

* add open state class to EntityMenu

* Add PinnedItemCard component

* prevent the bubbling of EntityMenu events

* replace class with styled-component stuff

* define a const

* Replace pinned collection items table with pinned overview section (#19787)

* Add PinnedItemOverview component

* Replace the pinned table with overview

* add types to collection utils

* fix pinning + types

* remvoe the old PinnedItemsTable

* fix/remove e2e tests that no longer make sense

* replace 'Datasets' with 'Models'

* Update frontend/src/metabase/collections/components/PinnedItemOverview/PinnedItemOverview.tsx

Co-authored-by: default avatarMaz Ameli <maz@metabase.com>

* add unique text for root collection

Co-authored-by: default avatarMaz Ameli <maz@metabase.com>

* Collections page UI changes (#19792)

* make a bunch of ui tweaks to collections

* resize Titles for PinnedItemCards

* resize collection description headings

* Add tooltip to pin button

* Fix unit test

* fix e2e tests

* add a default description

* Tbody --> TBody

* Hide long titles & add tooltip to show entire title

Co-authored-by: default avatarMaz Ameli <maz@metabase.com>

* Add card visualizations to the pinned section of collections (#19813)

* First pass at card viz in collections

* minor style fixes

* move redux stuff up to CollectionContent

* padding tweaks

* Make the entire card clickable

* add generic error message

* Add propTypes

* a little cleanup

* create ActionMenu component

* Fix pin action fn

* Fix circular dep & storybook story

* actually import the function

* add comment // use EventSandbox

* Add preventDefault prop to avoid breaking things

* Make pinned cards drag-and-droppable into the collections sidebar (#19829)

* first pass at dnd for pinned cards

* use cards instead of viz for performance

* fix type

* Add tests for collection changes (#19851)

* first pass at dnd for pinned cards

* use cards instead of viz for performance

* fix type

* Add tests for collection changes

* fix Button import

* remove async

* Add empty pinned items section banner (#19857)

Fix e2e test

don't show empty states when loading

styling tweaks

Fix test

* datasets --> models

* fix dragging data models

* Make question icons in collections bg-dark

Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
parent a4475dab
Branches
Tags
No related merge requests found
Showing
with 674 additions and 59 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment