Skip to content
Snippets Groups Projects
Unverified Commit b031c91e authored by Cal Herries's avatar Cal Herries Committed by GitHub
Browse files

Comment flaky test in...

Comment flaky test in metabase.metabot.metabot-util-test/inner-query-name-collisions-with-joins-test (#36786)
parent 26bbec63
No related branches found
No related tags found
No related merge requests found
......@@ -393,12 +393,13 @@
(let [model (update model :result_metadata
(fn [v]
(map #(assoc % :display_name "FOO") v)))
{:keys [column_aliases create_table_ddl]} (metabot-util/denormalize-model model)]
{:keys [column_aliases #_create_table_ddl]} (metabot-util/denormalize-model model)]
(is (= "\"TOTAL\" AS FOO, \"products__CATEGORY\" AS FOO_2, \"self__CATEGORY\" AS FOO_3"
column_aliases))
;; Ensure that the same aliases are used in the create table ddl
;; 7 = 3 for the column names + 2 for the type creation + 2 for the type references
(is (= 7 (count (re-seq #"FOO" create_table_ddl))))))))))
;; FIXME: This test is flaky on CI (metabase#36785)
#_(is (= 7 (count (re-seq #"FOO" create_table_ddl))))))))))
(deftest ^:parallel deconflicting-aliases-test
(testing "Test sql_name generation deconfliction:
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment