fix click behavior on pin maps (#16568)

* fix click behavior on pin maps

* fix repro parameterMapping

* allow click behavior on pin maps even without PK

frontend/src/metabase/visualizations/components/LeafletMarkerPinMap.jsx

@@ -86,17 +86,23 @@ export default class LeafletMarkerPinMap extends LeafletMap {
             },
           ],
         } = this.props;
+        // if there is a primary key then associate a pin with it
         const pkIndex = _.findIndex(cols, isPK);
-        if (pkIndex >= 0) {
-          // if there's a PK just use that for now
-          onVisualizationClick({
-            value: rows[rowIndex][pkIndex],
-            column: cols[pkIndex],
-            element: marker._icon,
-            origin: { row: rows[rowIndex], cols },
-            settings,
-          });
-        }
+        const hasPk = pkIndex >= 0;
+
+        const data = cols.map((col, index) => ({
+          col,
+          value: rows[rowIndex][index],
+        }));
+
+        onVisualizationClick({
+          value: hasPk ? rows[rowIndex][pkIndex] : null,
+          column: hasPk ? cols[pkIndex] : null,
+          element: marker._icon,
+          origin: { row: rows[rowIndex], cols },
+          settings,
+          data,
+        });
       });
     }
     return marker;

frontend/test/metabase/scenarios/dashboard/dashboard.cy.spec.js

@@ -146,7 +146,7 @@ describe("scenarios > dashboard", () => {
     cy.findByText("You're editing this dashboard.").should("not.exist");
   });
 
-  it.skip("should update a dashboard filter by clicking on a map pin (metabase#13597)", () => {
+  it("should update a dashboard filter by clicking on a map pin (metabase#13597)", () => {
     cy.createQuestion({
       name: "13597",
       query: {
@@ -162,6 +162,7 @@ describe("scenarios > dashboard", () => {
             {
               id: "92eb69ea",
               name: "ID",
+              sectionId: "id",
               slug: "id",
               type: "id",
             },
@@ -194,11 +195,13 @@ describe("scenarios > dashboard", () => {
                   click_behavior: {
                     type: "crossfilter",
                     parameterMapping: {
-                      id: "92eb69ea",
-                      source: { id: "ID", name: "ID", type: "column" },
-                      target: {
+                      "92eb69ea": {
                         id: "92eb69ea",
-                        type: "parameter",
+                        source: { id: "ID", name: "ID", type: "column" },
+                        target: {
+                          id: "92eb69ea",
+                          type: "parameter",
+                        },
                       },
                     },
                   },