-
- Downloads
Fix TypeError when changing click behavior to drill-through menu & default...
Fix TypeError when changing click behavior to drill-through menu & default click behavior does not have selected state (#35863) * fix: type error on click behavior change * chore: add comments * chore: tidy up comments * chore: reset changes * add aria-selected & selected drill-through menu assertion * chore: update assertion comment * refactor: move aria-selected inside selectable item * remove 'menu' from click behavior option * test: add e2e test fro 35354 * chore: clean up demo and update assertion * refactor: move assertion to existing scenario * chore: add log on e2e test * feat: update name for actionMenu * fix: unknown type in 34845 * fix: test after rebase * fix: remove unused union type "menu" * fix: use master version of click-behavior * fix: readd the tests * fix: e2e test * fix: remove set type selector after unset column * fix: show type selector when click behavior is undefined * fix: show type selector when finalClickBehavior is default (actionMenu)
Showing
- e2e/test/scenarios/dashboard-cards/click-behavior.cy.spec.js 14 additions, 10 deletionse2e/test/scenarios/dashboard-cards/click-behavior.cy.spec.js
- frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ClickBehaviorSidebar.tsx 4 additions, 1 deletion.../components/ClickBehaviorSidebar/ClickBehaviorSidebar.tsx
- frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/ClickBehaviorSidebarContent.tsx 2 additions, 1 deletion...ents/ClickBehaviorSidebar/ClickBehaviorSidebarContent.tsx
- frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/SidebarItem/SidebarItem.tsx 7 additions, 1 deletion...mponents/ClickBehaviorSidebar/SidebarItem/SidebarItem.tsx
- frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/TypeSelector/TypeSelector.tsx 4 additions, 4 deletions...onents/ClickBehaviorSidebar/TypeSelector/TypeSelector.tsx
- frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/hooks.ts 2 additions, 2 deletions...tabase/dashboard/components/ClickBehaviorSidebar/hooks.ts
- frontend/src/metabase/dashboard/components/ClickBehaviorSidebar/utils.ts 2 additions, 2 deletions...tabase/dashboard/components/ClickBehaviorSidebar/utils.ts
Loading
Please register or sign in to comment