fixes db perms error when permissionEditor is null (#41900)

b460b29f · Sloan Sparger · GitHub · 54aa2147 · b460b29f · b460b29f
Unverified Commit b460b29f authored 10 months ago by Sloan Sparger Committed by GitHub 10 months ago
--- a/frontend/src/metabase/admin/permissions/pages/DatabasePermissionsPage/DatabasesPermissionsPage.jsx
+++ b/frontend/src/metabase/admin/permissions/pages/DatabasePermissionsPage/DatabasesPermissionsPage.jsx
@@ -127,7 +127,7 @@ function DatabasesPermissionsPage({

  const showLegacyNoSelfServiceWarning =
    PLUGIN_ADVANCED_PERMISSIONS.shouldShowViewDataColumn &&
-    permissionEditor.hasLegacyNoSelfServiceValueInPermissionGraph;
+    !!permissionEditor?.hasLegacyNoSelfServiceValueInPermissionGraph;

  return (
    <Fragment>

--- a/frontend/src/metabase/admin/permissions/pages/GroupDataPermissionsPage/GroupsPermissionsPage.jsx
+++ b/frontend/src/metabase/admin/permissions/pages/GroupDataPermissionsPage/GroupsPermissionsPage.jsx
@@ -146,6 +146,7 @@ function GroupsPermissionsPage({
  const showLegacyNoSelfServiceWarning =
    PLUGIN_ADVANCED_PERMISSIONS.shouldShowViewDataColumn &&
    !!permissionEditor?.hasLegacyNoSelfServiceValueInPermissionGraph;
+
  return (
    <Fragment>
      <PermissionsSidebar