-
- Downloads
[MLv2] [FE] Migrate supportsImplicitActions (#37570)
* Move hasAnyClauses from steps.ts to query-utils - introduce query-utils file to avoid circular dependencies * Update comment * Update hasAnyClauses usage in Question * Rename hasAnyClauses to hasAnyClausesAtStage, introduce new hasAnyClauses * Rename query-utils.ts to stages.ts * Move stage-related utils from query.ts to stage.ts * Drop hasAnyClauses, rename hasAnyClausesAtStage to hasAnyClauses * Rename stages.ts to stage.ts to make it consistent with stage.cljc * Update function name * Format code * Update comment * Add is-stage-empty to MLv2 * Add Lib.isStageEmpty and replace hasAnyClauses with it * Fix typo in comment * Update comment * Update is-empty-clause to list all checked clauses * Improve readability * Export is-stage-empty via lib.core * Revert "Fix typo in comment" This reverts commit 286d412a5abe18589abc6f29b4774f39ff3d562a. * Update comment * Use implicit way of checking clauses presence in query * Inverse and rename is-stage-empty to has-clauses * Update comment * Fix drop-stage-if-empty * Use seq * Cast to boolean * Update src/metabase/lib/stage.cljc Co-authored-by:metamben <103100869+metamben@users.noreply.github.com> * Add question mark to has-clauses --------- Co-authored-by:
metamben <103100869+metamben@users.noreply.github.com>
Showing
- frontend/src/metabase-lib/Question.ts 1 addition, 2 deletionsfrontend/src/metabase-lib/Question.ts
- frontend/src/metabase-lib/query.ts 5 additions, 1 deletionfrontend/src/metabase-lib/query.ts
- frontend/src/metabase/query_builder/components/notebook/lib/steps.ts 4 additions, 24 deletions...c/metabase/query_builder/components/notebook/lib/steps.ts
- src/metabase/lib/core.cljc 2 additions, 1 deletionsrc/metabase/lib/core.cljc
- src/metabase/lib/js.cljs 5 additions, 0 deletionssrc/metabase/lib/js.cljs
- src/metabase/lib/stage.cljc 7 additions, 1 deletionsrc/metabase/lib/stage.cljc
- src/metabase/models/card.clj 1 addition, 2 deletionssrc/metabase/models/card.clj
Loading
Please register or sign in to comment