Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
b53a898e
Unverified
Commit
b53a898e
authored
7 months ago
by
Uladzimir Havenchyk
Committed by
GitHub
7 months ago
Browse files
Options
Downloads
Patches
Plain Diff
ci: move flaky specs to jail (#46715)
parent
bcd1a90c
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
2
Hide whitespace changes
Inline
Side-by-side
Showing
2 changed files
e2e/test/scenarios/question/column-compare.cy.spec.ts
+1
-1
1 addition, 1 deletion
e2e/test/scenarios/question/column-compare.cy.spec.ts
e2e/test/scenarios/question/saved.cy.spec.js
+38
-34
38 additions, 34 deletions
e2e/test/scenarios/question/saved.cy.spec.js
with
39 additions
and
35 deletions
e2e/test/scenarios/question/column-compare.cy.spec.ts
+
1
−
1
View file @
b53a898e
...
...
@@ -400,7 +400,7 @@ describeWithSnowplow("scenarios > question > column compare TODO", () => {
]);
});
it
(
"
breakout on non-datetime column
"
,
()
=>
{
it
(
"
breakout on non-datetime column
"
,
{
tags
:
"
@flaky
"
},
()
=>
{
createQuestion
(
{
query
:
QUERY_SINGLE_AGGREGATION_NON_DATETIME_BREAKOUT
},
{
visitQuestion
:
true
,
wrapId
:
true
,
idAlias
:
"
questionId
"
},
...
...
This diff is collapsed.
Click to expand it.
e2e/test/scenarios/question/saved.cy.spec.js
+
38
−
34
View file @
b53a898e
...
...
@@ -245,40 +245,44 @@ describe("scenarios > question > saved", () => {
});
});
it
(
"
'read-only' user should be able to resize column width (metabase#9772)
"
,
()
=>
{
cy
.
signIn
(
"
readonly
"
);
visitQuestion
(
ORDERS_QUESTION_ID
);
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy
.
findByText
(
"
Tax
"
)
.
closest
(
"
.test-TableInteractive-headerCellData
"
)
.
as
(
"
headerCell
"
)
.
then
(
$cell
=>
{
const
originalWidth
=
$cell
[
0
].
getBoundingClientRect
().
width
;
// Retries the assertion a few times to ensure it waits for DOM changes
// More context: https://github.com/metabase/metabase/pull/21823#discussion_r855302036
function
assertColumnResized
(
attempt
=
0
)
{
cy
.
get
(
"
@headerCell
"
).
then
(
$newCell
=>
{
const
newWidth
=
$newCell
[
0
].
getBoundingClientRect
().
width
;
if
(
newWidth
===
originalWidth
&&
attempt
<
3
)
{
cy
.
wait
(
100
);
assertColumnResized
(
++
attempt
);
}
else
{
expect
(
newWidth
).
to
.
be
.
gt
(
originalWidth
);
}
});
}
cy
.
wrap
(
$cell
)
.
find
(
"
.react-draggable
"
)
.
trigger
(
"
mousedown
"
,
0
,
0
,
{
force
:
true
})
.
trigger
(
"
mousemove
"
,
100
,
0
,
{
force
:
true
})
.
trigger
(
"
mouseup
"
,
100
,
0
,
{
force
:
true
});
assertColumnResized
();
});
});
it
(
"
'read-only' user should be able to resize column width (metabase#9772)
"
,
{
tags
:
"
@flaky
"
},
()
=>
{
cy
.
signIn
(
"
readonly
"
);
visitQuestion
(
ORDERS_QUESTION_ID
);
// eslint-disable-next-line no-unscoped-text-selectors -- deprecated usage
cy
.
findByText
(
"
Tax
"
)
.
closest
(
"
.test-TableInteractive-headerCellData
"
)
.
as
(
"
headerCell
"
)
.
then
(
$cell
=>
{
const
originalWidth
=
$cell
[
0
].
getBoundingClientRect
().
width
;
// Retries the assertion a few times to ensure it waits for DOM changes
// More context: https://github.com/metabase/metabase/pull/21823#discussion_r855302036
function
assertColumnResized
(
attempt
=
0
)
{
cy
.
get
(
"
@headerCell
"
).
then
(
$newCell
=>
{
const
newWidth
=
$newCell
[
0
].
getBoundingClientRect
().
width
;
if
(
newWidth
===
originalWidth
&&
attempt
<
3
)
{
cy
.
wait
(
100
);
assertColumnResized
(
++
attempt
);
}
else
{
expect
(
newWidth
).
to
.
be
.
gt
(
originalWidth
);
}
});
}
cy
.
wrap
(
$cell
)
.
find
(
"
.react-draggable
"
)
.
trigger
(
"
mousedown
"
,
0
,
0
,
{
force
:
true
})
.
trigger
(
"
mousemove
"
,
100
,
0
,
{
force
:
true
})
.
trigger
(
"
mouseup
"
,
100
,
0
,
{
force
:
true
});
assertColumnResized
();
});
},
);
it
(
"
should always be possible to view the full title text of the saved question
"
,
()
=>
{
visitQuestion
(
ORDERS_QUESTION_ID
);
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment