Skip to content
Snippets Groups Projects
Unverified Commit b5b9e882 authored by Paul Rosenzweig's avatar Paul Rosenzweig Committed by GitHub
Browse files

update fingerprint schema to allow for empty result text fingerprints (#12427)

parent 350018c3
Branches
Tags
No related merge requests found
import { signInAsNormalUser, restore, popover } from "__support__/cypress";
import {
signInAsNormalUser,
restore,
popover,
modal,
} from "__support__/cypress";
describe("scenarios > question > native", () => {
before(restore);
......@@ -182,4 +187,22 @@ describe("scenarios > question > native", () => {
cy.contains("580");
});
});
it("can save a question with no rows", () => {
cy.visit("/question/new");
cy.contains("Native query").click();
cy.get(".ace_content").type("select * from people where false");
cy.get(".NativeQueryEditor .Icon-play").click();
cy.contains("No results!");
cy.get(".Icon-contract").click();
cy.contains("Save").click();
modal().within(() => {
cy.findByLabelText("Name").type("empty question");
cy.findByText("Save").click();
});
// confirm that the question saved and url updated
cy.location("pathname").should("match", /\/question\/\d+/);
});
});
......@@ -112,7 +112,7 @@
{(s/optional-key :percent-json) (s/maybe Percent)
(s/optional-key :percent-url) (s/maybe Percent)
(s/optional-key :percent-email) (s/maybe Percent)
(s/optional-key :average-length) s/Num})
(s/optional-key :average-length) (s/maybe s/Num)})
(def TemporalFingerprint
"Schema for fingerprint information for Fields deriving from `:type/Temporal`."
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment