Improved version of column settings in ObjectDetail (#10110)

frontend/src/metabase/visualizations/visualizations/ObjectDetail.jsx

@@ -24,6 +24,8 @@ import {
   viewNextObjectDetail,
 } from "metabase/query_builder/actions";
 
+import { columnSettings } from "metabase/visualizations/lib/settings/column";
+
 import cx from "classnames";
 import _ from "underscore";
 
@@ -51,6 +53,10 @@ export class ObjectDetail extends Component {
 
   static hidden = true;
 
+  static settings = {
+    ...columnSettings({ hidden: true }),
+  };
+
   componentDidMount() {
     // load up FK references
     this.props.loadObjectDetailFKReferences();
@@ -85,7 +91,11 @@ export class ObjectDetail extends Component {
   };
 
   cellRenderer(column, value, isColumn) {
-    const { onVisualizationClick, visualizationIsClickable } = this.props;
+    const {
+      settings,
+      onVisualizationClick,
+      visualizationIsClickable,
+    } = this.props;
 
     let cellValue;
     let clicked;
@@ -108,8 +118,7 @@ export class ObjectDetail extends Component {
         cellValue = <pre className="ObjectJSON">{formattedJson}</pre>;
       } else {
         cellValue = formatValue(value, {
-          column: column,
-          ...column.settings,
+          ...settings.column(column),
           jsx: true,
           rich: true,
         });

frontend/test/metabase/visualizations/components/ObjectDetail.unit.spec.js

@@ -32,6 +32,7 @@ describe("ObjectDetail", () => {
           data={objectDetailCard.data}
           series={objectDetailCard}
           loadObjectDetailFKReferences={() => ({})}
+          settings={{ column: () => ({}) }}
         />,
       );