Skip to content
Snippets Groups Projects
Unverified Commit b62726d3 authored by Uladzimir Havenchyk's avatar Uladzimir Havenchyk Committed by GitHub
Browse files

Avoid heavy calculations on dashboard fetching (#43340)

parent 1610201f
No related branches found
No related tags found
No related merge requests found
......@@ -8,7 +8,6 @@ import {
getDashboardById,
getDashCardById,
getParameterValues,
getQuestions,
} from "metabase/dashboard/selectors";
import {
expandInlineDashboard,
......@@ -18,10 +17,8 @@ import Dashboards from "metabase/entities/dashboards";
import type { Deferred } from "metabase/lib/promise";
import { defer } from "metabase/lib/promise";
import { createAsyncThunk } from "metabase/lib/redux";
import { getDashboardUiParameters } from "metabase/parameters/utils/dashboards";
import { getParameterValuesByIdFromQueryParams } from "metabase/parameters/utils/parameter-values";
import { addFields, addParamValues } from "metabase/redux/metadata";
import { getMetadata } from "metabase/selectors/metadata";
import { AutoApi, DashboardApi, EmbedApi, PublicApi } from "metabase/services";
import type { Dashboard, DashboardCard, DashboardId } from "metabase-types/api";
......@@ -150,21 +147,12 @@ export const fetchDashboard = createAsyncThunk(
await dispatch(addFields(result.param_fields));
}
const metadata = getMetadata(getState());
const questions = getQuestions(getState());
const parameters = getDashboardUiParameters(
result.dashcards,
result.parameters,
metadata,
questions,
);
const lastUsedParametersValues = result["last_used_param_values"] ?? {};
const parameterValuesById = preserveParameters
? getParameterValues(getState())
: getParameterValuesByIdFromQueryParams(
parameters,
result.parameters ?? [],
queryParams,
lastUsedParametersValues,
);
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment