Skip to content
Snippets Groups Projects
Unverified Commit b63b0d28 authored by Anton Kulyk's avatar Anton Kulyk Committed by GitHub
Browse files

Fix accessing model cache error modal from URL (#22794)

parent 97026720
No related branches found
No related tags found
No related merge requests found
......@@ -8,6 +8,7 @@ import Link from "metabase/core/components/Link";
import ModalContent from "metabase/components/ModalContent";
import PersistedModels from "metabase/entities/persisted-models";
import { usePrevious } from "metabase/hooks/use-previous";
import { ModelCacheRefreshStatus } from "metabase-types/api";
......@@ -26,7 +27,6 @@ type ModelCacheRefreshJobModalStateProps = {
type PersistedModelsLoaderProps = {
persistedModel: ModelCacheRefreshStatus;
loading: boolean;
};
type ModelCacheRefreshJobModalProps = ModelCacheRefreshJobModalOwnProps &
......@@ -40,15 +40,21 @@ const mapDispatchToProps = {
function ModelCacheRefreshJobModal({
persistedModel,
loading,
onClose,
onRefresh,
}: ModelCacheRefreshJobModalProps) {
const prevModelInfo = usePrevious(persistedModel);
useEffect(() => {
if (loading === false && persistedModel?.state !== "error" && onClose) {
if (
!prevModelInfo &&
persistedModel &&
persistedModel.state !== "error" &&
onClose
) {
onClose();
}
}, [loading, persistedModel, onClose]);
}, [prevModelInfo, persistedModel, onClose]);
const footer = useMemo(() => {
if (!persistedModel) {
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment