Allow creating new items by inserting comma in MultiAutocomplete (#42824)
* Pass current values to shouldCreate * Allow comma to create new item * Simplify getAvailableSelectItems * Add unit test for MultiAutocomplete input * Use text instead of Text in paste * Handle spaces in MultiAutocomplete * Remove cast * Reuse last var * Use haveLastBeenCalledWith over haveBeenCalledWith * Handle pasting when there is text in the input already * Accept quote-delimited values * Add info icon * Handle tab as a separator * Fix test cases for unsanitized parseValues * Add csv-parse * Use csv-parse to parse values * Apply the correct color to the info icon * Rename util to utils * Break up tooltip text * Only return unique values * Be more accepting around quotes in the middle of unescaped values * provide Buffer for csv-parse package in storybook * Use browser-friendly version of csv-parse * Remove unused eslint rule * Add specital case for csv-parse to jest config * Put uniqueness check in each state update * Only add partial value if it is valid * Only add partial value if it is valid * Fix test case for FilterValuePicker * Just use Set Co-authored-by:Kamil Mielnik <kamil@kamilmielnik.com> * Allow parsing more than one value * Use isValid everywhere it makes sense * Add test for RTL languages --------- Co-authored-by:
Aleksandr Lesnenko <alxnddr@gmail.com> Co-authored-by:
Kamil Mielnik <kamil@kamilmielnik.com>
Showing
- .storybook/main.js 8 additions, 1 deletion.storybook/main.js
- frontend/src/metabase/querying/components/FilterValuePicker/FilterValuePicker.tsx 4 additions, 4 deletions...erying/components/FilterValuePicker/FilterValuePicker.tsx
- frontend/src/metabase/querying/components/FilterValuePicker/FilterValuePicker.unit.spec.tsx 3 additions, 1 deletion...ponents/FilterValuePicker/FilterValuePicker.unit.spec.tsx
- frontend/src/metabase/querying/components/FilterValuePicker/ListValuePicker/ListValuePicker.tsx 1 addition, 1 deletion...nts/FilterValuePicker/ListValuePicker/ListValuePicker.tsx
- frontend/src/metabase/querying/components/FilterValuePicker/SearchValuePicker/SearchValuePicker.tsx 1 addition, 1 deletion...FilterValuePicker/SearchValuePicker/SearchValuePicker.tsx
- frontend/src/metabase/querying/components/FilterValuePicker/StaticValuePicker/StaticValuePicker.tsx 1 addition, 1 deletion...FilterValuePicker/StaticValuePicker/StaticValuePicker.tsx
- frontend/src/metabase/ui/components/inputs/MultiAutocomplete/MultiAutocomplete.module.css 3 additions, 0 deletions...nts/inputs/MultiAutocomplete/MultiAutocomplete.module.css
- frontend/src/metabase/ui/components/inputs/MultiAutocomplete/MultiAutocomplete.tsx 118 additions, 38 deletions...components/inputs/MultiAutocomplete/MultiAutocomplete.tsx
- frontend/src/metabase/ui/components/inputs/MultiAutocomplete/MultiAutocomplete.unit.spec.tsx 285 additions, 0 deletions.../inputs/MultiAutocomplete/MultiAutocomplete.unit.spec.tsx
- frontend/src/metabase/ui/components/inputs/MultiAutocomplete/utils.ts 21 additions, 0 deletions.../metabase/ui/components/inputs/MultiAutocomplete/utils.ts
- frontend/src/metabase/ui/components/inputs/MultiAutocomplete/utils.unit.spec.ts 24 additions, 0 deletions...ui/components/inputs/MultiAutocomplete/utils.unit.spec.ts
- jest.config.js 2 additions, 0 deletionsjest.config.js
- package.json 1 addition, 0 deletionspackage.json
- yarn.lock 5 additions, 0 deletionsyarn.lock
Loading
Please register or sign in to comment