Apply schema inclusion/exclusion filtering to sql-jdbc drivers (#19651)
* Apply schema inclusion/exclusion filtering to sql-jdbc drivers Update `sql-jdbc` namespaces to handle schema inclusion/exclusion patterns when filtering schemas Add new generic schema inclusion/exclusion test for sql-jdbc drivers that define the property Update Snowflake and Redshift driver manifests to include schema filtering property Create `db-details->schema-filter-patterns` util fn to turn DB details into the inclusion/exclusion patterns Move schema inclusion/exclusion filtering code to new namespace (since it's not strictly used by `:sql-jdbc` derived drivers) Move existing tests accordingly Add schema inclusion/exclusion check to the new `filtered-syncable-schemas` multimethod (and updating docstring) Change `:redshift` impl of `filtered-syncable-schemas` to call the `:sql-jdbc` version instead Use new multimethod instead for `filtered-syncable-schemas`, and have default impl of `syncable-schemas` call that Mark `syncable-schemas` as deprecated and include notes on the new method (and update driver markdown file accordingly)
Showing
- docs/developers-guide/driver-changelog.md 8 additions, 0 deletionsdocs/developers-guide/driver-changelog.md
- modules/drivers/bigquery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj 5 additions, 5 deletions...uery-cloud-sdk/src/metabase/driver/bigquery_cloud_sdk.clj
- modules/drivers/redshift/resources/metabase-plugin.yaml 3 additions, 0 deletionsmodules/drivers/redshift/resources/metabase-plugin.yaml
- modules/drivers/redshift/src/metabase/driver/redshift.clj 8 additions, 8 deletionsmodules/drivers/redshift/src/metabase/driver/redshift.clj
- modules/drivers/redshift/test/metabase/driver/redshift_test.clj 10 additions, 6 deletions...s/drivers/redshift/test/metabase/driver/redshift_test.clj
- modules/drivers/redshift/test/metabase/test/data/redshift.clj 10 additions, 9 deletions...les/drivers/redshift/test/metabase/test/data/redshift.clj
- modules/drivers/snowflake/resources/metabase-plugin.yaml 3 additions, 4 deletionsmodules/drivers/snowflake/resources/metabase-plugin.yaml
- modules/drivers/snowflake/src/metabase/driver/snowflake.clj 8 additions, 2 deletionsmodules/drivers/snowflake/src/metabase/driver/snowflake.clj
- src/metabase/driver/sql_jdbc/sync.clj 1 addition, 0 deletionssrc/metabase/driver/sql_jdbc/sync.clj
- src/metabase/driver/sql_jdbc/sync/describe_database.clj 35 additions, 45 deletionssrc/metabase/driver/sql_jdbc/sync/describe_database.clj
- src/metabase/driver/sql_jdbc/sync/interface.clj 28 additions, 3 deletionssrc/metabase/driver/sql_jdbc/sync/interface.clj
- src/metabase/driver/sync.clj 62 additions, 0 deletionssrc/metabase/driver/sync.clj
- src/metabase/driver/util.clj 7 additions, 0 deletionssrc/metabase/driver/util.clj
- test/metabase/driver/sql_jdbc/sync/describe_database_test.clj 51 additions, 26 deletions.../metabase/driver/sql_jdbc/sync/describe_database_test.clj
- test/metabase/driver/sync_test.clj 26 additions, 0 deletionstest/metabase/driver/sync_test.clj
Loading
Please register or sign in to comment