HK: remove noPopover and unnecessary function from ParameterValueWidget (#37736)

frontend/src/metabase/components/TextWidget/TextWidget.tsx

@@ -35,8 +35,6 @@ export class TextWidget extends Component<Props, State> {
     };
   }
 
-  static noPopover = true;
-
   UNSAFE_componentWillMount() {
     this.UNSAFE_componentWillReceiveProps(this.props);
   }

frontend/src/metabase/parameters/components/ParameterValueWidget.jsx

@@ -99,7 +99,7 @@ class ParameterValueWidget extends Component {
     } = this.props;
     const { isFocused } = this.state;
     const hasValue = value != null;
-    const { noPopover } = getWidgetDefinition(parameter);
+    const noPopover = hasNoPopover(parameter);
     const parameterTypeIcon = getParameterIconName(parameter);
     const showTypeIcon = !isEditing && !hasValue && !isFocused;
 
@@ -127,7 +127,7 @@ class ParameterValueWidget extends Component {
           <WidgetStatusIcon
             isFullscreen={isFullscreen}
             hasValue={hasValue}
-            noPopover={!!noPopover}
+            noPopover={noPopover}
             isFocused={isFocused}
             setValue={setValue}
           />
@@ -170,7 +170,7 @@ class ParameterValueWidget extends Component {
               <WidgetStatusIcon
                 isFullscreen={isFullscreen}
                 hasValue={hasValue}
-                noPopover={!!noPopover}
+                noPopover={noPopover}
                 isFocused={isFocused}
                 setValue={setValue}
               />
@@ -289,18 +289,13 @@ Widget.propTypes = {
   onFocusChanged: PropTypes.func.isRequired,
 };
 
-function getWidgetDefinition(parameter) {
-  if (DATE_WIDGETS[parameter.type]) {
-    return DATE_WIDGETS[parameter.type];
-  } else if (isTextWidget(parameter)) {
-    return TextWidget;
-  } else if (isNumberParameter(parameter)) {
-    return NumberInputWidget;
-  } else if (isFieldWidget(parameter)) {
-    return ParameterFieldWidget;
-  } else {
-    return StringInputWidget;
+function hasNoPopover(parameter) {
+  // This is needed because isTextWidget check isn't complete,
+  // and returns true for dates too.
+  if (isDateParameter(parameter)) {
+    return false;
   }
+  return isTextWidget(parameter);
 }
 
 function isTextWidget(parameter) {