Skip to content
Snippets Groups Projects
Unverified Commit b81a929f authored by Dalton's avatar Dalton Committed by GitHub
Browse files

Add DimensionInfoPopover to Table column headers (#19350)


* Add DimensionInfoPopover to TableInteractive column headers

* check for missing query before parsing dimension

* Don't render DimensionInfoPopover until all dependent data is available

* Add a min/max width to the DimensionInfoPopover content

* Don't show DimensionInfoPopover when user has no metadata

* Add e2e test for table column header popover

* some styling tweaks

* Move field value fetching back to FieldValuesList

* table styling tweaks

* lint fix

* add loading state for field values

* handle alternate field values format

* Format numbers

* make comment more specific

* Fix e2e test

* changes per review

* reconcile some styling differences btwn Dimension and Table popovers

Co-authored-by: default avatarMaz Ameli <maz@metabase.com>
parent 3e9d7795
No related branches found
No related tags found
No related merge requests found
Showing
with 591 additions and 251 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment