Skip to content
Snippets Groups Projects
Commit b885a4ad authored by Atte Keinänen's avatar Atte Keinänen
Browse files

Fix Flow errors

parent f066be8e
No related branches found
No related tags found
No related merge requests found
......@@ -56,6 +56,7 @@ declare module "underscore" {
declare function pick(o: {[key: any]: any}, ...properties: string[]): {[key: any]: any};
declare function pick(o: {[key: any]: any}, predicate: (val: any, key: any, object: {[key: any]: any})=>boolean): {[key: any]: any};
declare function pluck(o: Array<{[key: any]: any}>, propertyNames: string): Array<any>;
declare function has(o: {[key: any]: any}, ...properties: string[]): boolean;
declare function difference<T>(array: T[], ...others: T[][]): T[];
......
......@@ -9,12 +9,15 @@ import StructuredQuery from "metabase-lib/lib/queries/StructuredQuery";
import type { Filter } from "metabase/meta/types/Query";
import Dimension from "metabase-lib/lib/Dimension";
import type { TableMetadata } from "metabase/meta/types/Metadata";
type Props = {
query: StructuredQuery,
filters: Array<Filter>,
removeFilter?: (index: number) => void,
updateFilter?: (index: number, filter: Filter) => void,
maxDisplayValues?: number
maxDisplayValues?: number,
tableMetadata?: TableMetadata // legacy parameter
};
type State = {
......@@ -57,7 +60,7 @@ export default class FilterList extends Component {
<FilterWidget
key={index}
placeholder="Item"
// $FlowFixMe: update widgets that are still passing tableMetadata instead of query
// TODO: update widgets that are still passing tableMetadata instead of query
query={query || {
table: () => tableMetadata,
parseFieldReference: (fieldRef) => Dimension.parseMBQL(fieldRef, tableMetadata)
......
......@@ -32,7 +32,7 @@ export const ERROR_MESSAGE_PERMISSION = "Sorry, you don't have permission to see
import Question from "metabase-lib/lib/Question";
import type { Card as CardObject, VisualizationSettings } from "metabase/meta/types/Card";
import type { HoverObject, ClickObject, Series, OnChangeCardAndRun } from "metabase/meta/types/Visualization";
import type { Metadata } from "metabase/meta/types/Metadata";
import Metadata from "metabase-lib/lib/metadata/Metadata";
type Props = {
series: Series,
......@@ -229,7 +229,6 @@ export default class Visualization extends Component {
const { series, clicked } = this.state;
const index = seriesIndex || (clicked && clicked.seriesIndex) || 0;
// $FlowFixMe
const previousCard: ?CardObject = series && series[index] && series[index].card;
this.props.onChangeCardAndRun({ nextCard, previousCard });
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment