Do not break waterfall when there is 0 in the series (#16687)

* Do not break waterfall when there is a null

frontend/src/metabase/visualizations/lib/LineAreaBarRenderer.js

@@ -893,7 +893,7 @@ export default function lineAreaBar(
 
   datas.map(data => {
     data.map(d => {
-      if (d._waterfallValue) {
+      if (isFinite(d._waterfallValue)) {
         d[1] = d._waterfallValue;
       }
     });

frontend/src/metabase/visualizations/lib/chart_values.js

@@ -99,7 +99,7 @@ export function onRenderValueLabels(
           !showAll && barCount > 1 && isBarLike(display) && barWidth < 20;
         return { x, y, showLabelBelow, seriesIndex, rotated, hidden };
       })
-      .filter(d => !(isBarLike(display) && d.y === 0));
+      .filter(d => !(display === "bar" && d.y === 0));
 
     if (display === "waterfall" && data.length > 0) {
       let total = 0;

frontend/test/metabase/scenarios/visualizations/waterfall.cy.spec.js

@@ -152,7 +152,7 @@ describe("scenarios > visualizations > waterfall", () => {
     cy.get(".Visualization .bar");
   });
 
-  it.skip("should display correct values when one of them is 0 (metabase#16246)", () => {
+  it("should display correct values when one of them is 0 (metabase#16246)", () => {
     visitQuestionAdhoc({
       dataset_query: {
         type: "native",
@@ -181,6 +181,35 @@ describe("scenarios > visualizations > waterfall", () => {
       .should("eq", "0.1");
   });
 
+  it("should display correct values when one of them is null (metabase#16246)", () => {
+    visitQuestionAdhoc({
+      dataset_query: {
+        type: "native",
+        native: {
+          query:
+            "SELECT * FROM (\nVALUES \n('a',2),\n('b',1),\n('c',-0.5),\n('d',-0.5),\n('e',0.1),\n('f',null),\n('g', -2)\n)\n",
+          "template-tags": {},
+        },
+        database: 1,
+      },
+      display: "waterfall",
+      visualization_settings: {
+        "graph.show_values": true,
+      },
+    });
+
+    cy.get(".value-label")
+      .as("labels")
+      .eq(-3)
+      .invoke("text")
+      .should("eq", "0");
+
+    cy.get("@labels")
+      .last()
+      .invoke("text")
+      .should("eq", "0.1");
+  });
+
   describe("scenarios > visualizations > waterfall settings", () => {
     beforeEach(() => {
       restore();