Skip to content
Snippets Groups Projects
Unverified Commit b9d974ba authored by Daniel Higginbotham's avatar Daniel Higginbotham Committed by GitHub
Browse files

4779 locked params (#10878)

* starting to put together warning component

* progress toward embed code warnings

* prettify

* sync params/embedding params, show warning

* prety

* comment goodness

* fix types I think?

* trying to get the flow types right

* finish fixing types

* pretty

* implement tom's cleanup suggestions

* prettier again

* fix issue with editing params multiple times

* prettier

* fix issue with 'adding dashcard' ruining my carefully crafted embed warning code

* handle empty dashboards

* prettier

* handle case where there are no embedded params

* Revert "fix issue with 'adding dashcard' ruining my carefully crafted embed warning code"

This reverts commit 50852b89386ddedb58e527b8b3b6e1b3c3f624d6.

* restore behavior of entering edit mode after adding card

* implement tom's suggestion for editwarning

* unit tests for syncParametersAndEmbeddingParams
parent 445da0e1
No related branches found
No related tags found
No related merge requests found
Showing with 150 additions and 19 deletions
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment