4779 locked params (#10878)
* starting to put together warning component * progress toward embed code warnings * prettify * sync params/embedding params, show warning * prety * comment goodness * fix types I think? * trying to get the flow types right * finish fixing types * pretty * implement tom's cleanup suggestions * prettier again * fix issue with editing params multiple times * prettier * fix issue with 'adding dashcard' ruining my carefully crafted embed warning code * handle empty dashboards * prettier * handle case where there are no embedded params * Revert "fix issue with 'adding dashcard' ruining my carefully crafted embed warning code" This reverts commit 50852b89386ddedb58e527b8b3b6e1b3c3f624d6. * restore behavior of entering edit mode after adding card * implement tom's suggestion for editwarning * unit tests for syncParametersAndEmbeddingParams
Showing
- frontend/src/metabase/components/EditWarning.jsx 18 additions, 0 deletionsfrontend/src/metabase/components/EditWarning.jsx
- frontend/src/metabase/components/Header.jsx 8 additions, 0 deletionsfrontend/src/metabase/components/Header.jsx
- frontend/src/metabase/dashboard/components/AddToDashSelectQuestionModal.jsx 1 addition, 1 deletion...ase/dashboard/components/AddToDashSelectQuestionModal.jsx
- frontend/src/metabase/dashboard/components/Dashboard.jsx 6 additions, 5 deletionsfrontend/src/metabase/dashboard/components/Dashboard.jsx
- frontend/src/metabase/dashboard/components/DashboardGrid.jsx 2 additions, 1 deletionfrontend/src/metabase/dashboard/components/DashboardGrid.jsx
- frontend/src/metabase/dashboard/components/DashboardHeader.jsx 24 additions, 6 deletions...end/src/metabase/dashboard/components/DashboardHeader.jsx
- frontend/src/metabase/dashboard/dashboard.js 35 additions, 4 deletionsfrontend/src/metabase/dashboard/dashboard.js
- frontend/src/metabase/meta/types/Dashboard.js 2 additions, 0 deletionsfrontend/src/metabase/meta/types/Dashboard.js
- frontend/src/metabase/parameters/components/Parameters.jsx 3 additions, 1 deletionfrontend/src/metabase/parameters/components/Parameters.jsx
- frontend/test/metabase/dashboard/dashboard.unit.spec.js 51 additions, 1 deletionfrontend/test/metabase/dashboard/dashboard.unit.spec.js
Loading
Please register or sign in to comment