MLv2: fix :relative-datetime schema (#29747) (#30019)

src/metabase/lib/schema/expression/temporal.cljc

@@ -127,9 +127,9 @@
    [:= :current]
    :int])
 
-(mbql-clause/define-tuple-mbql-clause :relative-datetime :- :type/DateTime
-  #_n    [:ref ::relative-datetime.amount]
-  #_unit [:ref ::temporal-bucketing/unit.date-time.interval])
+(mbql-clause/define-catn-mbql-clause :relative-datetime :- :type/DateTime
+  [:n    [:schema [:ref ::relative-datetime.amount]]]
+  [:unit [:? [:schema [:ref ::temporal-bucketing/unit.date-time.interval]]]])
 
 (mbql-clause/define-tuple-mbql-clause :time :- :type/Time
   #_:timestr [:schema [:ref ::expression/string]]

test/metabase/lib/schema/expression/temporal_test.cljc

@@ -55,3 +55,12 @@
              {:lib/uuid "202ec127-f7b9-49ce-b785-cd7b96996660"}
              [:field {:temporal-unit :default, :lib/uuid "cde9c9d4-c399-4808-8476-24b65842ba82"} 1]
              :year-of-era]))))
+
+(deftest ^:parallel relative-datetime-test
+  (are [clause] (not (mc/explain :mbql.clause/relative-datetime clause))
+    [:relative-datetime {:lib/uuid "00000000-0000-0000-0000-000000000000"} -1 :day]
+    [:relative-datetime {:lib/uuid "00000000-0000-0000-0000-000000000000"} -1 :minute]
+    [:relative-datetime {:lib/uuid "00000000-0000-0000-0000-000000000000"} 0 :day]
+    [:relative-datetime {:lib/uuid "00000000-0000-0000-0000-000000000000"} :current :day]
+    [:relative-datetime {:lib/uuid "00000000-0000-0000-0000-000000000000"} :current :minute]
+    [:relative-datetime {:lib/uuid "00000000-0000-0000-0000-000000000000"} :current]))

test/metabase/query_processor_test/test_mlv2.clj

@@ -35,10 +35,6 @@
   [legacy-query]
   (or
    *skip-conversion-tests*
-   ;; #29747: schema for `:relative-datetime` current without a unit is broken
-   (mbql.u/match-one legacy-query
-     [:relative-datetime :current]
-     "#29747")
    ;; #29898: `:joins` with `:fields` other than `:all` or `:none` are not normalized correctly.
    (mbql.u/match-one legacy-query
      {:joins joins}