Fix metabase lib returning the string "null" as the drill through value (#44234)

* Convert drill-through (CLJ) values to JS

* Convert the drill-through `:null` to an actual `null`

Resolves #44232

* Use new function in `filter-drill-details`

* display-info->js should check for nil before seqable?

* fix js object comparison

* Add test for the `drill-value->js` function

* Simplify the test

* Fix the JS object equality in the test

---------

Co-authored-by: Alexander Solovyov <alexander@solovyov.net>

src/metabase/lib/drill_thru/common.cljc

@@ -41,3 +41,8 @@
   "Does the source table for this `query` have more than one primary key?"
   [query]
   (> (count (lib.metadata.calculation/primary-keys query)) 1))
+
+(defn drill-value->js
+  "Convert a drill value to a JS value"
+  [value]
+  (if (= value :null) nil value))

src/metabase/lib/drill_thru/quick_filter.cljc

@@ -131,6 +131,7 @@
 (defmethod lib.drill-thru.common/drill-thru-info-method :drill-thru/quick-filter
   [_query _stage-number drill-thru]
   (-> (select-keys drill-thru [:type :operators :value])
+      (update :value lib.drill-thru.common/drill-value->js)
       (update :operators (fn [operators]
                            (mapv :name operators)))))
 

src/metabase/lib/js.cljs

@@ -65,6 +65,7 @@
    [metabase.lib.cache :as lib.cache]
    [metabase.lib.convert :as lib.convert]
    [metabase.lib.core :as lib.core]
+   [metabase.lib.drill-thru.common :as lib.drill-thru.common]
    [metabase.lib.equality :as lib.equality]
    [metabase.lib.expression :as lib.expression]
    [metabase.lib.field :as lib.field]
@@ -368,6 +369,8 @@
   Recursively converts CLJS maps and sequences into JS objects and arrays."
   [x]
   (cond
+    ;; `(seqable? nil) ; => true`, so we need to check for it before
+    (nil? x)     nil
     ;; Note that map? is only true for CLJS maps, not JS objects.
     (map? x)     (display-info-map->js x)
     (string? x)  x
@@ -1968,7 +1971,7 @@
   #js {"column"     column
        "query"      a-query
        "stageIndex" stage-number
-       "value"      (if (= value :null) nil value)})
+       "value"      (lib.drill-thru.common/drill-value->js value)})
 
 (defn ^:export aggregation-drill-details
   "Returns a JS object with the details needed to render the complex UI for `compare-aggregation` drills.

test/metabase/lib/drill_thru_test.cljc

@@ -5,6 +5,7 @@
    [malli.error :as me]
    [medley.core :as m]
    [metabase.lib.core :as lib]
+   [metabase.lib.drill-thru.common :as lib.drill-thru.common]
    [metabase.lib.drill-thru.test-util :as lib.drill-thru.tu]
    [metabase.lib.field :as-alias lib.field]
    [metabase.lib.schema :as lib.schema]
@@ -822,3 +823,9 @@
                        :initial-op {:short :=}}
                       {:type            :drill-thru/sort
                        :sort-directions [:asc :desc]}]})))
+
+(deftest ^:parallel drill-value->js-test
+  (testing "should convert :null to nil"
+    (doseq [[input expected] [[:null nil]
+                              [nil nil] ]]
+      (is (= expected (lib.drill-thru.common/drill-value->js input))))))

test/metabase/lib/js_test.cljs

@@ -668,3 +668,15 @@
               (is (=? (lib/append-stage agg-only)
                       (.-query obj)))
               (is (=? -1 (.-stageIndex obj))))))))))
+
+(deftest ^:parallel display-info->js-test
+  (testing "all data structures are converted correctly"
+    (let [input        {:arr [:a {:inner true}]
+                        :string  "passed"
+                        :keyword :too
+                        :value   nil}
+          expected #js {:arr #js ["a" #js {:inner true}]
+                        :string  "passed"
+                        :keyword "too"
+                        :value   nil}]
+      (is (js= expected (lib.js/display-info->js input))))))