Skip to content
Snippets Groups Projects
Unverified Commit bd17d680 authored by Cam Saul's avatar Cam Saul
Browse files

Test fixes :wrench:

parent 635d9ef4
Branches
Tags
No related merge requests found
Hide whitespace changes
Inline Side-by-side
frontend/test/parameters/parameters.integ.spec.js
+ 2
− 2
View file @ bd17d680
......@@ -439,10 +439,10 @@ async function sharedParametersTests(getAppAndStore) {
widget => widget.find(TokenField).props().placeholder,
);
expect(placeholders).toEqual([
"Search by Name or enter an ID",
"Enter an ID",
"Search by Name",
"Search the list",
"Search by Name or enter an ID",
"Enter an ID",
]);
});
......
frontend/test/services/MetabaseApi.integ.spec.js
+ 3
− 1
View file @ bd17d680
......@@ -20,7 +20,9 @@ function stripKeys(object) {
// handles both arrays and objects
if (object && typeof object === "object") {
for (const key in object) {
if (/^((updated|created)_at|last_analyzed)$/.test(key)) {
if (
/^((updated|created)_at|last_analyzed|timezone|is_on_demand)$/.test(key)
) {
delete object[key];
} else {
stripKeys(object[key]);
......
frontend/test/services/__snapshots__/MetabaseApi.integ.spec.js.snap
+ 195
− 44
View file @ bd17d680
......@@ -22,13 +22,11 @@ Object {
],
"id": 1,
"is_full_sync": true,
"is_on_demand": false,
"is_sample": true,
"metadata_sync_schedule": "0 0 * * * ? *",
"name": "Sample Dataset",
"options": null,
"points_of_interest": null,
"timezone": "America/Chicago",
},
"db_id": 1,
"description": "This is a confirmed order for a product from a user.",
......@@ -432,7 +430,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 1,
"max_value": null,
"min_value": null,
......@@ -524,7 +522,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 35,
"max_value": null,
"min_value": null,
......@@ -563,7 +561,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 2,
"max_value": 17624,
"min_value": 1,
......@@ -602,7 +600,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": 24,
"has_field_values": "search",
"has_field_values": "none",
"id": 3,
"max_value": 200,
"min_value": 1,
......@@ -656,9 +654,62 @@ Object {
"base_type": "type/Integer",
"caveats": null,
"database_type": "INTEGER",
"default_dimension_option": null,
"default_dimension_option": Object {
"mbql": Array [
"binning-strategy",
null,
"default",
],
"name": "Auto bin",
"type": "type/Number",
},
"description": "Number of products bought.",
"dimension_options": Array [],
"dimension_options": Array [
Object {
"mbql": Array [
"binning-strategy",
null,
"default",
],
"name": "Auto bin",
"type": "type/Number",
},
Object {
"mbql": Array [
"binning-strategy",
null,
"num-bins",
10,
],
"name": "10 bins",
"type": "type/Number",
},
Object {
"mbql": Array [
"binning-strategy",
null,
"num-bins",
50,
],
"name": "50 bins",
"type": "type/Number",
},
Object {
"mbql": Array [
"binning-strategy",
null,
"num-bins",
100,
],
"name": "100 bins",
"type": "type/Number",
},
Object {
"mbql": null,
"name": "Don't bin",
"type": "type/Number",
},
],
"dimensions": Array [],
"display_name": "Quantity",
"fingerprint": Object {
......@@ -675,7 +726,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "list",
"id": 36,
"max_value": null,
"min_value": null,
......@@ -685,7 +736,7 @@ Object {
"position": 0,
"preview_display": true,
"raw_column_id": null,
"special_type": "type/Category",
"special_type": null,
"table_id": 1,
"target": null,
"visibility_type": "normal",
......@@ -695,9 +746,62 @@ Object {
"base_type": "type/Float",
"caveats": null,
"database_type": "DOUBLE",
"default_dimension_option": null,
"default_dimension_option": Object {
"mbql": Array [
"binning-strategy",
null,
"default",
],
"name": "Auto bin",
"type": "type/Number",
},
"description": "The raw, pre-tax cost of the order. Note that this might be different in the future from the product price due to promotions, credits, etc.",
"dimension_options": Array [],
"dimension_options": Array [
Object {
"mbql": Array [
"binning-strategy",
null,
"default",
],
"name": "Auto bin",
"type": "type/Number",
},
Object {
"mbql": Array [
"binning-strategy",
null,
"num-bins",
10,
],
"name": "10 bins",
"type": "type/Number",
},
Object {
"mbql": Array [
"binning-strategy",
null,
"num-bins",
50,
],
"name": "50 bins",
"type": "type/Number",
},
Object {
"mbql": Array [
"binning-strategy",
null,
"num-bins",
100,
],
"name": "100 bins",
"type": "type/Number",
},
Object {
"mbql": null,
"name": "Don't bin",
"type": "type/Number",
},
],
"dimensions": Array [],
"display_name": "Subtotal",
"fingerprint": Object {
......@@ -714,7 +818,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "list",
"has_field_values": "none",
"id": 4,
"max_value": 99.37,
"min_value": 12.02,
......@@ -724,7 +828,7 @@ Object {
"position": 0,
"preview_display": true,
"raw_column_id": 12,
"special_type": "type/Category",
"special_type": null,
"table_id": 1,
"target": null,
"visibility_type": "normal",
......@@ -806,7 +910,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 5,
"max_value": 7.45,
"min_value": 0,
......@@ -898,7 +1002,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 6,
"max_value": 106.82000000000001,
"min_value": 12.02,
......@@ -937,7 +1041,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": 13,
"has_field_values": "search",
"has_field_values": "none",
"id": 7,
"max_value": 2498,
"min_value": 2,
......@@ -1022,13 +1126,11 @@ Object {
],
"id": 1,
"is_full_sync": true,
"is_on_demand": false,
"is_sample": true,
"metadata_sync_schedule": "0 0 * * * ? *",
"name": "Sample Dataset",
"options": null,
"points_of_interest": null,
"timezone": "America/Chicago",
},
"db_id": 1,
"description": "This is a user account. Note that employees and customer support staff will have accounts.",
......@@ -1472,7 +1574,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 9,
"max_value": null,
"min_value": null,
......@@ -1688,7 +1790,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 11,
"max_value": null,
"min_value": null,
......@@ -1767,7 +1869,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 13,
"max_value": 2500,
"min_value": 1,
......@@ -1869,7 +1971,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 14,
"max_value": 89.98241873383432,
"min_value": -89.96310010740648,
......@@ -1971,7 +2073,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 15,
"max_value": 179.73650520575882,
"min_value": -179.30480334715446,
......@@ -2222,13 +2324,11 @@ Object {
],
"id": 1,
"is_full_sync": true,
"is_on_demand": false,
"is_sample": true,
"metadata_sync_schedule": "0 0 * * * ? *",
"name": "Sample Dataset",
"options": null,
"points_of_interest": null,
"timezone": "America/Chicago",
},
"db_id": 1,
"description": "This is our product catalog. It includes all products ever sold by the Sample Company.",
......@@ -2672,7 +2772,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 22,
"max_value": null,
"min_value": null,
......@@ -2712,7 +2812,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "list",
"has_field_values": "search",
"id": 23,
"max_value": null,
"min_value": null,
......@@ -2722,7 +2822,7 @@ Object {
"position": 0,
"preview_display": true,
"raw_column_id": 3,
"special_type": "type/Category",
"special_type": null,
"table_id": 3,
"target": null,
"visibility_type": "normal",
......@@ -2751,7 +2851,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 24,
"max_value": 200,
"min_value": 1,
......@@ -2771,9 +2871,62 @@ Object {
"base_type": "type/Float",
"caveats": null,
"database_type": "DOUBLE",
"default_dimension_option": null,
"default_dimension_option": Object {
"mbql": Array [
"binning-strategy",
null,
"default",
],
"name": "Auto bin",
"type": "type/Number",
},
"description": "The list price of the product. Note that this is not always the price the product sold for due to discounts, promotions, etc.",
"dimension_options": Array [],
"dimension_options": Array [
Object {
"mbql": Array [
"binning-strategy",
null,
"default",
],
"name": "Auto bin",
"type": "type/Number",
},
Object {
"mbql": Array [
"binning-strategy",
null,
"num-bins",
10,
],
"name": "10 bins",
"type": "type/Number",
},
Object {
"mbql": Array [
"binning-strategy",
null,
"num-bins",
50,
],
"name": "50 bins",
"type": "type/Number",
},
Object {
"mbql": Array [
"binning-strategy",
null,
"num-bins",
100,
],
"name": "100 bins",
"type": "type/Number",
},
Object {
"mbql": null,
"name": "Don't bin",
"type": "type/Number",
},
],
"dimensions": Array [],
"display_name": "Price",
"fingerprint": Object {
......@@ -2790,7 +2943,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "list",
"has_field_values": "none",
"id": 25,
"max_value": 99.37,
"min_value": 12.02,
......@@ -2800,7 +2953,7 @@ Object {
"position": 0,
"preview_display": true,
"raw_column_id": 5,
"special_type": "type/Category",
"special_type": null,
"table_id": 3,
"target": null,
"visibility_type": "normal",
......@@ -2869,7 +3022,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "list",
"has_field_values": "search",
"id": 27,
"max_value": null,
"min_value": null,
......@@ -2879,7 +3032,7 @@ Object {
"position": 0,
"preview_display": true,
"raw_column_id": 7,
"special_type": "type/Category",
"special_type": null,
"table_id": 3,
"target": null,
"visibility_type": "normal",
......@@ -2909,7 +3062,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "list",
"has_field_values": "search",
"id": 28,
"max_value": null,
"min_value": null,
......@@ -2919,7 +3072,7 @@ Object {
"position": 0,
"preview_display": true,
"raw_column_id": 8,
"special_type": "type/Category",
"special_type": null,
"table_id": 3,
"target": null,
"visibility_type": "normal",
......@@ -2960,13 +3113,11 @@ Object {
],
"id": 1,
"is_full_sync": true,
"is_on_demand": false,
"is_sample": true,
"metadata_sync_schedule": "0 0 * * * ? *",
"name": "Sample Dataset",
"options": null,
"points_of_interest": null,
"timezone": "America/Chicago",
},
"db_id": 1,
"description": "These are reviews our customers have left on products. Note that these are not tied to orders so it is possible people have reviewed products they did not purchase from us.",
......@@ -3225,7 +3376,7 @@ Object {
},
"type": Object {
"type/Text": Object {
"average-length": 178.65040650406505,
"average-length": 178.66056910569105,
"percent-email": 0,
"percent-json": 0,
"percent-url": 0,
......@@ -3410,7 +3561,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 30,
"max_value": null,
"min_value": null,
......@@ -3449,7 +3600,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": null,
"has_field_values": "search",
"has_field_values": "none",
"id": 31,
"max_value": 1078,
"min_value": 1,
......@@ -3488,7 +3639,7 @@ Object {
},
"fingerprint_version": 1,
"fk_target_field_id": 24,
"has_field_values": "search",
"has_field_values": "none",
"id": 32,
"max_value": 200,
"min_value": 1,
......
0% or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment