Skip to content
Snippets Groups Projects
Commit bd23dc92 authored by Kyle Doherty's avatar Kyle Doherty
Browse files

code review - add some proptypes cause types are neat.

parent e8a1ef7b
No related branches found
No related tags found
Loading
......@@ -4,7 +4,6 @@ import React, { Component, PropTypes } from "react";
import Icon from "metabase/components/Icon.react";
export default class AccordianItem extends Component {
render() {
......@@ -28,10 +27,16 @@ export default class AccordianItem extends Component {
{children}
</div>
</div>
:
null
}
: null }
</div>
);
}
}
AccordianItem.propTypes = {
onClickFn: PropTypes.func.isRequired,
itemId: PropTypes.number.isRequired,
isOpen: PropTypes.bool.isRequired,
title: PropTypes.string.isRequired,
children: PropTypes.element.isRequired
}
"use strict";
'use strict';
import React, { Component, PropTypes } from "react";
import _ from "underscore";
import cx from "classnames";
import React, { Component, PropTypes } from 'react';
import _ from 'underscore';
import cx from 'classnames';
import LoadingAndErrorWrapper from "metabase/components/LoadingAndErrorWrapper.react";
import LoadingAndErrorWrapper from 'metabase/components/LoadingAndErrorWrapper.react';
import ActivityItem from './ActivityItem.react';
import ActivityStory from './ActivityStory.react';
import { fetchActivity } from "../actions";
import { fetchActivity } from '../actions';
import Urls from "metabase/lib/urls";
import Urls from 'metabase/lib/urls';
export default class Activity extends Component {
......@@ -187,3 +187,7 @@ export default class Activity extends Component {
);
}
}
Activity.propTypes = {
user: PropTypes.object.isRequired,
}
'use strict';
import React, { Component } from 'react';
import React, { Component, PropTypes } from 'react';
import Icon from 'metabase/components/Icon.react';
import IconBorder from 'metabase/components/IconBorder.react';
import UserAvatar from 'metabase/components/UserAvatar.react';
......@@ -26,7 +26,6 @@ export default class ActivityItem extends Component {
<span className="text-dark">{description.userName}</span>
&nbsp;{description.subject}&nbsp;
{ description.subjectRefName && description.subjectRefLink ?
<a className="link text-dark" href={description.subjectRefLink}>{description.subjectRefName}</a>
: null }
......@@ -43,3 +42,9 @@ export default class ActivityItem extends Component {
)
}
}
ActivityItem.propTypes = {
item: PropTypes.object.isRequired,
description: PropTypes.object.isRequired,
userColors: PropTypes.string
}
'use strict';
import React, { Component } from 'react';
import React, { Component, PropTypes } from 'react';
export default class ActivityStory extends Component {
......@@ -33,3 +33,7 @@ export default class ActivityStory extends Component {
)
}
}
ActivityStory.propTypes = {
story: PropTypes.object.isRequired
}
......@@ -49,3 +49,7 @@ export default class HeaderTabs extends Component {
);
}
}
HeaderTabs.propTypes = {
selectedTab: PropTypes.string.isRequired
}
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment