[MLv2] Full `:column`s for `:dimensions` in `available-drill-thrus` (#34810)
Previously only the `:column-name` was provided, and there is a self-proclaimed "icky hack" to guess at the full columns. The FE provides the (JSON) columns, so this PR converts and uses them. The icky hack can be removed. `:column-ref` is included because sometimes it's important that the refs use the same UUID.
Showing
- frontend/src/metabase-lib/drills.unit.spec.ts 1 addition, 0 deletionsfrontend/src/metabase-lib/drills.unit.spec.ts
- src/metabase/lib/convert.cljc 27 additions, 0 deletionssrc/metabase/lib/convert.cljc
- src/metabase/lib/drill_thru.cljc 9 additions, 44 deletionssrc/metabase/lib/drill_thru.cljc
- src/metabase/lib/drill_thru/object_details.cljc 2 additions, 2 deletionssrc/metabase/lib/drill_thru/object_details.cljc
- src/metabase/lib/drill_thru/quick_filter.cljc 1 addition, 1 deletionsrc/metabase/lib/drill_thru/quick_filter.cljc
- src/metabase/lib/drill_thru/zoom_in_timeseries.cljc 31 additions, 39 deletionssrc/metabase/lib/drill_thru/zoom_in_timeseries.cljc
- src/metabase/lib/js.cljs 32 additions, 23 deletionssrc/metabase/lib/js.cljs
- src/metabase/lib/js/metadata.cljs 16 additions, 14 deletionssrc/metabase/lib/js/metadata.cljs
- src/metabase/lib/schema/drill_thru.cljc 8 additions, 23 deletionssrc/metabase/lib/schema/drill_thru.cljc
- test/metabase/lib/drill_thru/distribution_test.cljc 3 additions, 2 deletionstest/metabase/lib/drill_thru/distribution_test.cljc
- test/metabase/lib/drill_thru/sort_test.cljc 10 additions, 6 deletionstest/metabase/lib/drill_thru/sort_test.cljc
- test/metabase/lib/drill_thru/summarize_column_by_time_test.cljc 3 additions, 2 deletions...etabase/lib/drill_thru/summarize_column_by_time_test.cljc
- test/metabase/lib/drill_thru/test_util.cljc 14 additions, 8 deletionstest/metabase/lib/drill_thru/test_util.cljc
- test/metabase/lib/drill_thru/zoom_in_timeseries_test.cljc 31 additions, 17 deletionstest/metabase/lib/drill_thru/zoom_in_timeseries_test.cljc
- test/metabase/lib/drill_thru_test.cljc 141 additions, 98 deletionstest/metabase/lib/drill_thru_test.cljc
Loading
Please register or sign in to comment