Skip to content
Snippets Groups Projects
Unverified Commit bfbfb7ab authored by Anton Kulyk's avatar Anton Kulyk Committed by GitHub
Browse files

Fix missing `slack_colorized` icon (#32144)

* Fix missing `slack_colorized` icon

* Convert `NewPulseSidebar` to TypeScript
parent 240bd6f1
Branches
Tags
No related merge requests found
......@@ -291,6 +291,8 @@ import sidebar_open_component from "./sidebar_open.svg?component";
import sidebar_open_source from "./sidebar_open.svg?source";
import slack_component from "./slack.svg?component";
import slack_source from "./slack.svg?source";
import slack_colorized_component from "./slack_colorized.svg?component";
import slack_colorized_source from "./slack_colorized.svg?source";
import smartscalar_component from "./smartscalar.svg?component";
import smartscalar_source from "./smartscalar.svg?source";
import snippet_component from "./snippet.svg?component";
......@@ -929,6 +931,10 @@ export const Icons = {
component: slack_component,
source: slack_source,
},
slack_colorized: {
component: slack_colorized_component,
source: slack_colorized_source,
},
smartscalar: {
component: smartscalar_component,
source: smartscalar_source,
......
/* eslint "react/prop-types": "error" */
import PropTypes from "prop-types";
import cx from "classnames";
import { t, jt } from "ttag";
import { Icon } from "metabase/core/components/Icon";
......@@ -9,13 +6,21 @@ import Link from "metabase/core/components/Link";
import Sidebar from "metabase/dashboard/components/Sidebar";
import { ChannelCard } from "metabase/sharing/components/NewPulseSidebar.styled";
function NewPulseSidebar({
interface NewPulseSidebarProps {
emailConfigured: boolean;
slackConfigured: boolean;
onNewEmailPulse: () => void;
onNewSlackPulse: () => void;
onCancel: () => void;
}
export function NewPulseSidebar({
onCancel,
emailConfigured,
slackConfigured,
onNewEmailPulse,
onNewSlackPulse,
}) {
}: NewPulseSidebarProps) {
return (
<Sidebar onCancel={onCancel}>
<div className="mt2 pt2 px4">
......@@ -47,7 +52,6 @@ function NewPulseSidebar({
>{t`Email it`}</h3>
</div>
<Text
lineHeight={1.5}
className={cx("text-medium", {
"hover-child hover--inherit": emailConfigured,
})}
......@@ -86,7 +90,6 @@ function NewPulseSidebar({
>{t`Send it to Slack`}</h3>
</div>
<Text
lineHeight={1.5}
className={cx("text-medium", {
"hover-child hover--inherit": slackConfigured,
})}
......@@ -106,13 +109,3 @@ function NewPulseSidebar({
</Sidebar>
);
}
NewPulseSidebar.propTypes = {
onCancel: PropTypes.func.isRequired,
emailConfigured: PropTypes.bool.isRequired,
slackConfigured: PropTypes.bool.isRequired,
onNewEmailPulse: PropTypes.func.isRequired,
onNewSlackPulse: PropTypes.func.isRequired,
};
export default NewPulseSidebar;
......@@ -5,7 +5,7 @@ import PropTypes from "prop-types";
import _ from "underscore";
import { connect } from "react-redux";
import NewPulseSidebar from "metabase/sharing/components/NewPulseSidebar";
import { NewPulseSidebar } from "metabase/sharing/components/NewPulseSidebar";
import PulsesListSidebar from "metabase/sharing/components/PulsesListSidebar";
import {
AddEditSlackSidebar,
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment