Skip to content
Snippets Groups Projects
Unverified Commit c08f918a authored by Cal Herries's avatar Cal Herries Committed by GitHub
Browse files

Dan's suggestions (#30576)

parent a8fc67d6
No related branches found
No related tags found
No related merge requests found
......@@ -71,7 +71,7 @@
;;
;; Check for permissions and throw 403 if we don't have them...
(if include_editable_data_model
(api/write-check 'Table (:table_id field))
(api/write-check Table (:table_id field))
(throw-if-no-read-or-segmented-perms field))
;; ...but if we do, return the Field <3
field))
......
......@@ -117,13 +117,15 @@
:nfc_path nil}
original-val)))
(let [;; set it
response (mt/user-http-request :crowberto :put 200 (format "field/%d" field-id) {:name "something else"
:display_name "yay"
:description "foobar"
:semantic_type :type/Name
:json_unfolding true
:visibility_type :sensitive
:nfc_path ["bob" "dobbs"]})
response (mt/user-http-request :crowberto :put 200
(format "field/%d" field-id)
{:name "something else"
:display_name "yay"
:description "foobar"
:semantic_type :type/Name
:json_unfolding true
:visibility_type :sensitive
:nfc_path ["bob" "dobbs"]})
updated-val (simple-field-details (t2/select-one Field :id field-id))]
(testing "response body should be the updated field"
(is (= {:name "Field Test"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment