Skip to content
Snippets Groups Projects
Unverified Commit c1cfdd9f authored by Cal Herries's avatar Cal Herries Committed by GitHub
Browse files

Revive flaky redshift tests (#40391)

parent fc8711b7
Branches
Tags
No related merge requests found
......@@ -130,9 +130,7 @@
mt/process-query
mt/rows)))))
(finally
;; comment out since it's causing flake
;; can uncomment after we tackle #40058
#_(doseq [statement [(format "DROP TABLE IF EXISTS %s.table_with_access;" schema)
(doseq [statement [(format "DROP TABLE IF EXISTS %s.table_with_access;" schema)
(format "DROP TABLE IF EXISTS %s.table_without_access;" schema)
(format "DROP SCHEMA IF EXISTS %s;" schema)
(format "DROP USER IF EXISTS %s;" user)]]
......
......@@ -269,7 +269,7 @@
(t2/select-fn-set :name Table :db_id (u/the-id database)) ; the new view should have been synced without errors
view-nm))
(let [table-id (t2/select-one-pk Table :db_id (u/the-id database), :name view-nm)]
;; and its columns' :base_type should have been identified correctly
;; and its columns' :base_type should have been identified correctly
(is (= [{:name "case_when_numeric_inc_nulls", :database_type "numeric", :base_type :type/Decimal}
{:name "raw_null", :database_type "character varying", :base_type :type/Text}
{:name "raw_var", :database_type "character varying", :base_type :type/Text}]
......@@ -459,9 +459,7 @@
:delete false}}
(get-privileges))))
(finally
;; comment out since it's causing flake
;; can uncomment after we tackle #40058
#_(execute! (format
(execute! (format
(str
"DROP TABLE IF EXISTS %2$s CASCADE;\n"
"DROP VIEW IF EXISTS %3$s CASCADE;\n"
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment