Custom expression editor: decouple suggestions and diagnostics (#18773)

With the suggestions and highlighting being done through via lexical analysis
only, there is no need to run the computationally-expensive syntactical
analysis on every keystroke anymore. We only need to do that when the
user finishes the editing and wants to use the expression.