add cypress helper to visit an adhoc question (#14165)

frontend/test/__support__/cypress.js

@@ -304,3 +304,12 @@ function addQADatabase(engine, db_display_name, port) {
     expect(status).to.equal(200);
   });
 }
+
+export function visitQuestionAdhoc(question) {
+  if (question.display) {
+    // without "locking" the display, the QB will run its picking logic and override the setting
+    question = Object.assign({}, question, { displayIsLocked: true });
+  }
+  const hash = btoa(unescape(encodeURIComponent(JSON.stringify(question))));
+  cy.visit("/question#" + hash);
+}

frontend/test/metabase/scenarios/visualizations/pivot_tables.cy.spec.js

-import { signInAsAdmin, restore } from "__support__/cypress";
+import {
+  signInAsAdmin,
+  restore,
+  visitQuestionAdhoc,
+} from "__support__/cypress";
 import { SAMPLE_DATASET } from "__support__/cypress_sample_dataset";
 
 const { ORDERS, ORDERS_ID, PRODUCTS, PEOPLE } = SAMPLE_DATASET;
@@ -12,17 +16,11 @@ describe("scenarios > visualizations > pivot tables", () => {
   });
 
   it("should be created from an ad-hoc question", () => {
-    // We're intentionally setting the visualization to `bar` here
-    createAndVisitTestQuestion({ display: "bar" });
-
-    // By changing the visualization type, we make this an "ad-hoc" question
-    cy.findByText("Visualization").click();
-    cy.get(".Icon-pivot_table")
-      .should("be.visible")
-      .click();
+    visitQuestionAdhoc({ dataset_query: testQuery, display: "pivot" });
 
     cy.findByText(/Count by Users? → Source and Products? → Category/); // ad-hoc title
 
+    cy.findByText("Settings").click();
     assertOnPivotSettings();
     assertOnPivotTable();
   });
@@ -107,25 +105,27 @@ describe("scenarios > visualizations > pivot tables", () => {
   });
 });
 
+const testQuery = {
+  type: "query",
+  query: {
+    "source-table": ORDERS_ID,
+    aggregation: [["count"]],
+    breakout: [
+      ["fk->", ["field-id", ORDERS.USER_ID], ["field-id", PEOPLE.SOURCE]],
+      [
+        "fk->",
+        ["field-id", ORDERS.PRODUCT_ID],
+        ["field-id", PRODUCTS.CATEGORY],
+      ],
+    ],
+  },
+  database: 1,
+};
+
 function createAndVisitTestQuestion({ display = "pivot" } = {}) {
   cy.request("POST", "/api/card", {
     name: QUESTION_NAME,
-    dataset_query: {
-      type: "query",
-      query: {
-        "source-table": ORDERS_ID,
-        aggregation: [["count"]],
-        breakout: [
-          ["fk->", ["field-id", ORDERS.USER_ID], ["field-id", PEOPLE.SOURCE]],
-          [
-            "fk->",
-            ["field-id", ORDERS.PRODUCT_ID],
-            ["field-id", PRODUCTS.CATEGORY],
-          ],
-        ],
-      },
-      database: 1,
-    },
+    dataset_query: testQuery,
     display,
     description: null,
     visualization_settings: {},