Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package Registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
c46e3628
Unverified
Commit
c46e3628
authored
2 years ago
by
Noah Moss
Committed by
GitHub
2 years ago
Browse files
Options
Downloads
Patches
Plain Diff
fix flaky test (#25894)
parent
09f98f6f
Loading
Loading
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
test/metabase/models/database_test.clj
+3
-4
3 additions, 4 deletions
test/metabase/models/database_test.clj
with
3 additions
and
4 deletions
test/metabase/models/database_test.clj
+
3
−
4
View file @
c46e3628
...
...
@@ -52,7 +52,6 @@
(
is
(
schema=
{
:description
(
s/eq
(
format
"sync-and-analyze Database %d"
db-id
))
:key
(
s/eq
(
format
"metabase.task.sync-and-analyze.trigger.%d"
db-id
))
:misfire-instruction
(
s/eq
"DO_NOTHING"
)
:state
(
s/eq
"NORMAL"
)
:may-fire-again?
(
s/eq
true
)
:schedule
(
s/eq
"0 50 * * * ? *"
)
:final-fire-time
(
s/eq
nil
)
...
...
@@ -215,9 +214,9 @@
(
testing
" updating the value works as expected"
(
db/update!
Database
id
:details
(
assoc
details
:password-path
"/path/to/my/password-file"
))
(
check-db-fn
(
db/select-one
Database
:id
id
)
{
:kind
:password
:source
:file-path
:version
2
:value
"/path/to/my/password-file"
}))))
:source
:file-path
:version
2
:value
"/path/to/my/password-file"
}))))
(
testing
"Secret instances are deleted from the app DB when the DatabaseInstance is deleted"
(
is
(
seq
@
secret-ids
)
"At least one Secret instance should have been created"
)
(
doseq
[
secret-id
@
secret-ids
]
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment