Skip to content
Snippets Groups Projects
Unverified Commit c5b4d044 authored by metamben's avatar metamben Committed by GitHub
Browse files

Add test after speculative fix (#31633)

parent e3d05176
No related branches found
No related tags found
No related merge requests found
......@@ -2,7 +2,10 @@
(:require
[clojure.test :refer [deftest is testing]]
[metabase.lib.core :as lib]
[metabase.lib.test-metadata :as meta]))
[metabase.lib.metadata.calculation :as lib.metadata.calculation]
[metabase.lib.metadata.protocols :as metadata.protocols]
[metabase.lib.test-metadata :as meta]
[metabase.util.malli :as mu]))
(deftest ^:parallel join-table-metadata-test
(testing "You should be able to pass :metadata/table to lib/join"
......@@ -22,3 +25,18 @@
[:field {} (meta/id :venues :category-id)]
[:field {:join-alias "Cat"} (meta/id :categories :id)]]]}]}]}
query)))))
(deftest ^:parallel nil-column-test
(testing "Fields with missing names shouldn't blow up visible-columns"
(let [metadata-provider
(reify
metadata.protocols/MetadataProvider
(database [_this] (metadata.protocols/database meta/metadata-provider))
(table [_this table-id] (metadata.protocols/table meta/metadata-provider table-id))
(field [_this field-id] (assoc (metadata.protocols/field meta/metadata-provider field-id) :name nil))
(tables [_this] (metadata.protocols/tables meta/metadata-provider))
(fields [_this table-id] (mapv #(assoc % :name nil)
(metadata.protocols/fields meta/metadata-provider table-id))))
query (lib/query-for-table-name metadata-provider "VENUES")]
(binding [mu/*enforce* false]
(is (sequential? (lib.metadata.calculation/visible-columns query)))))))
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment