Skip to content
Snippets Groups Projects
Commit c5d15b2a authored by Cam Saül's avatar Cam Saül
Browse files

Add a unit test :100:

parent f83fbcae
No related branches found
No related tags found
No related merge requests found
......@@ -112,13 +112,16 @@
(integer? user-id)
(string? revision_message)]}
;; update the segment itself
(db/update-non-nil-keys! Segment id
:name name
:description description
:caveats caveats
:points_of_interest points_of_interest
:show_in_getting_started show_in_getting_started
:definition definition)
(db/update! Segment id
(merge
{:name name
:description description
:caveats caveats
:definition definition}
(when (seq points_of_interest)
{:points_of_interest points_of_interest})
(when (not (nil? show_in_getting_started))
{:show_in_getting_started show_in_getting_started})))
(u/prog1 (retrieve-segment id)
(events/publish-event :segment-update (assoc <> :actor_id user-id, :revision_message revision_message))))
......
......@@ -10,7 +10,8 @@
[table :refer [Table]])
[metabase.test.data.users :refer :all]
[metabase.test.data :refer :all]
[metabase.test.util :as tu]))
[metabase.test.util :as tu]
[metabase.util :as u]))
;; ## Helper Fns
......@@ -358,10 +359,19 @@
;;; GET /api/segement/
(tu/expect-with-temp [Segment [segment-1]
Segment [segment-2]
Segment [_ {:is_active false}]] ; inactive segments shouldn't show up
(tu/mappify (hydrate [segment-1
segment-2] :creator))
((user->client :rasta) :get 200 "segment/"))
;;; PUT /api/segment/id. Can I update a segment's name without specifying `:points_of_interest` and `:show_in_getting_started`?
(tu/expect-with-temp [Segment [segment]]
:ok
(do ((user->client :crowberto) :put 200 (str "segment/" (u/get-id segment))
{:name "Cool name"
:revision_message "WOW HOW COOL"
:definition {}})
:ok))
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment