Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
c6981778
Commit
c6981778
authored
8 years ago
by
Tom Robinson
Browse files
Options
Downloads
Patches
Plain Diff
Move npm install into circle dependencies
parent
a2b4a50b
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
3
Hide whitespace changes
Inline
Side-by-side
Showing
3 changed files
bin/build
+12
-9
12 additions, 9 deletions
bin/build
bin/ci
+2
-2
2 additions, 2 deletions
bin/ci
circle.yml
+1
-1
1 addition, 1 deletion
circle.yml
with
15 additions
and
12 deletions
bin/build
+
12
−
9
View file @
c6981778
...
...
@@ -17,16 +17,19 @@ version() {
fi
}
frontend
()
{
if
[
-
z
$
{
WEBPACK_OPTS
+
x
}
];
then
WEBPACK_OPTS
=
"
-p
"
fi
npm
-
install
()
{
echo
"
Running
'
npm install
'
to download javascript dependencies...
"
&&
npm
install
&&
npm
install
}
frontend
()
{
echo
"
Running
'
webpack -p
'
to assemble and minify frontend assets...
"
&&
.
/
node_modules
/
.
bin
/
webpack
-
p
}
echo
"
Running
'
webpack $WEBPACK_OPTS
'
to assemble and minify frontend assets...
"
&&
.
/
node_modules
/
.
bin
/
webpack
$
WEBPACK_OPTS
frontend
-
fast
()
{
echo
"
Running
'
webpack
'
to assemble and minify frontend assets...
"
&&
.
/
node_modules
/
.
bin
/
webpack
--
devtool
eval
}
sample
-
dataset
()
{
...
...
@@ -44,7 +47,7 @@ uberjar() {
}
all
()
{
version
&&
frontend
&&
sample
-
dataset
&&
uberjar
version
&&
npm
-
install
&&
frontend
&&
sample
-
dataset
&&
uberjar
}
# Default to running all but let someone specify one or more sub-tasks to run instead if desired
...
...
This diff is collapsed.
Click to expand it.
bin/ci
+
2
−
2
View file @
c6981778
...
...
@@ -6,6 +6,6 @@ case $CIRCLE_NODE_INDEX in
2
)
ENGINES
=
h2,postgres,sqlite,crate
MB_DB_TYPE
=
mysql
MB_DB_DBNAME
=
circle_test
MB_DB_PORT
=
3306
MB_DB_USER
=
ubuntu
MB_DB_HOST
=
localhost lein
test
;;
3
)
ENGINES
=
h2,redshift,druid lein
test
;;
4
)
lein eastwood
&&
lein bikeshed
&&
lein docstring-checker
&&
./bin/reflection-linter
;;
5
)
npm
install
&&
npm
run lint
&&
npm run
test
;;
6
)
WEBPACK_OPTS
=
""
./bin/build
&&
npm run test-e2e
;;
5
)
npm run lint
&&
npm run
test
;;
6
)
./bin/build version frontend-fast sample-dataset uberjar
&&
npm run test-e2e
;;
esac
This diff is collapsed.
Click to expand it.
circle.yml
+
1
−
1
View file @
c6981778
...
...
@@ -24,8 +24,8 @@ dependencies:
-
sudo service crate restart
-
lein deps
-
pip install awscli==1.7.3
-
npm cache clean
-
npm install -g npm@2.15.9
-
npm install
database
:
post
:
# MySQL doesn't load named timezone information automatically, you have to run this command to load it
...
...
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment