Test to help debug #9844 (#11068)

modules/drivers/redshift/src/metabase/driver/redshift.clj

@@ -92,7 +92,7 @@
 
 (defmethod sql-jdbc.conn/connection-details->spec :redshift [_ {:keys [host port db], :as opts}]
   (merge
-   {:classname                     "com.amazon.redshift.jdbc.Driver" ; must be in classpath
+   {:classname                     "com.amazon.redshift.jdbc.Driver"
     :subprotocol                   "redshift"
     :subname                       (str "//" host ":" port "/" db)
     :ssl                           true

modules/drivers/redshift/test/metabase/driver/redshift_test.clj

 (ns metabase.driver.redshift-test
-  (:require [metabase.test.data.datasets :refer [expect-with-driver]]
-            [metabase.test.util :as tu]))
+  (:require [clojure.test :refer :all]
+            [metabase.test
+             [fixtures :as fixtures]
+             [util :as tu]]
+            [metabase.test.data.datasets :refer [expect-with-driver]]))
+
+(use-fixtures :once (fixtures/initialize :plugins))
 
 (expect-with-driver :redshift
   "UTC"
   (tu/db-timezone-id))
+
+(deftest correct-driver-test
+  (is (= "com.amazon.redshift.jdbc.Driver"
+         (.getName (class (jdbc-proxy/wrapped-driver (java.sql.DriverManager/getDriver "jdbc:redshift://host:5432/testdb")))))
+      "Make sure we're using the correct driver for Redshift"))

src/metabase/plugins/jdbc_proxy.clj

@@ -4,13 +4,28 @@
   (:require [clojure.tools.logging :as log]
             [metabase.plugins.classloader :as classloader]
             [metabase.util :as u]
-            [metabase.util.i18n :refer [trs]])
+            [metabase.util.i18n :refer [trs]]
+            [potemkin.types :as p.types]
+            [pretty.core :refer [PrettyPrintable]])
   (:import [java.sql Driver DriverManager]))
 
 ;;; -------------------------------------------------- Proxy Driver --------------------------------------------------
 
+(p.types/defprotocol+ ^:private ProxyDriver
+  (wrapped-driver [this]
+    "Get the JDBC driver wrapped by a Metabase JDBC proxy driver."))
+
 (defn- proxy-driver ^Driver [^Driver driver]
-  (reify Driver
+  (reify
+    PrettyPrintable
+    (pretty [_]
+      (list 'proxy-driver driver))
+
+    ProxyDriver
+    (wrapped-driver [_]
+      driver)
+
+    Driver
     (acceptsURL [_ url]
       (.acceptsURL driver url))
     (connect [_ url info]