Skip to content
Snippets Groups Projects
Commit c7b5a4db authored by Tom Robinson's avatar Tom Robinson
Browse files

Fix: Dashboard parameter widgets don't show correct field options for...

Fix: Dashboard parameter widgets don't show correct field options for city/state/zip/country widgets
parent 7db90031
No related branches found
No related tags found
No related merge requests found
......@@ -11,6 +11,7 @@ import { getTemplateTags } from "./Card";
import { slugify, stripId } from "metabase/lib/formatting";
import Query from "metabase/lib/query";
import { TYPE, isa } from "metabase/lib/types";
import _ from "underscore";
......@@ -201,10 +202,15 @@ function fieldFilterForParameter(parameter: ParameterObject): FieldFilter {
const [type, subtype] = parameter.type.split("/");
switch (type) {
case "date": return (field: Field) => field.isDate();
case "location": return (field: Field) => field.special_type === subtype;
case "id": return (field: Field) => field.isID();
case "category": return (field: Field) => field.isCategory();
}
switch (parameter.type) {
case "location/city": return (field: Field) => isa(field.special_type, TYPE.City);
case "location/state": return (field: Field) => isa(field.special_type, TYPE.State);
case "location/zip_code": return (field: Field) => isa(field.special_type, TYPE.ZipCode);
case "location/country": return (field: Field) => isa(field.special_type, TYPE.Country);
}
return (field: Field) => false;
}
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment