Merge pull request #8226 from metabase/fix-ldap-settings

Fix LDAP setting validation

frontend/src/metabase/admin/settings/components/widgets/LdapGroupMappingsWidget.jsx

@@ -46,10 +46,14 @@ export default class LdapGroupMappingsWidget extends React.Component {
     };
   }
 
-  _showEditModal = (e: Event) => {
+  _showEditModal = async (e: Event) => {
     e.preventDefault();
+    // just load the setting again to make sure it's up to date
+    const setting = _.findWhere(await SettingsApi.list(), {
+      key: "ldap-group-mappings",
+    });
     this.setState({
-      mappings: this.props.settingValues["ldap-group-mappings"] || {},
+      mappings: (setting && setting.value) || {},
       showEditModal: true,
     });
     PermissionsApi.groups().then(groups => this.setState({ groups }));

frontend/src/metabase/admin/settings/selectors.js

@@ -252,13 +252,11 @@ const SECTIONS = [
         display_name: t`User filter`,
         type: "string",
         validations: [
-          [
-            value =>
-              (value.match(/\(/g) || []).length !==
-              (value.match(/\)/g) || []).length
-                ? t`Check your parentheses`
-                : null,
-          ],
+          value =>
+            (value.match(/\(/g) || []).length !==
+            (value.match(/\)/g) || []).length
+              ? t`Check your parentheses`
+              : null,
         ],
       },
       {