Skip to content
GitLab
Explore
Sign in
Primary navigation
Search or go to…
Project
M
Metabase
Manage
Activity
Members
Labels
Plan
Issues
Issue boards
Milestones
Iterations
Wiki
Requirements
Code
Merge requests
Repository
Branches
Commits
Tags
Repository graph
Compare revisions
Snippets
Locked files
Build
Pipelines
Jobs
Pipeline schedules
Test cases
Artifacts
Deploy
Releases
Package registry
Container Registry
Model registry
Operate
Environments
Terraform modules
Monitor
Incidents
Service Desk
Analyze
Value stream analytics
Contributor analytics
CI/CD analytics
Repository analytics
Code review analytics
Issue analytics
Insights
Model experiments
Help
Help
Support
GitLab documentation
Compare GitLab plans
Community forum
Contribute to GitLab
Provide feedback
Terms and privacy
Keyboard shortcuts
?
Snippets
Groups
Projects
Show more breadcrumbs
Engineering Digital Service
Metabase
Commits
c8ab535c
Unverified
Commit
c8ab535c
authored
1 year ago
by
Alexander Polyankin
Committed by
GitHub
1 year ago
Browse files
Options
Downloads
Patches
Plain Diff
Filter modal date tests (#37218)
parent
927f29b1
No related branches found
Branches containing commit
No related tags found
Tags containing commit
No related merge requests found
Changes
1
Hide whitespace changes
Inline
Side-by-side
Showing
1 changed file
frontend/src/metabase/querying/components/FilterModal/DateFilterEditor/DateFilterEditor.unit.spec.tsx
+215
-0
215 additions, 0 deletions
...lterModal/DateFilterEditor/DateFilterEditor.unit.spec.tsx
with
215 additions
and
0 deletions
frontend/src/metabase/querying/components/FilterModal/DateFilterEditor/DateFilterEditor.unit.spec.tsx
0 → 100644
+
215
−
0
View file @
c8ab535c
import
userEvent
from
"
@testing-library/user-event
"
;
import
{
renderWithProviders
,
screen
}
from
"
__support__/ui
"
;
import
*
as
Lib
from
"
metabase-lib
"
;
import
{
columnFinder
,
createQuery
}
from
"
metabase-lib/test-helpers
"
;
import
{
DateFilterEditor
}
from
"
./DateFilterEditor
"
;
interface
SetupOpts
{
query
:
Lib
.
Query
;
stageIndex
:
number
;
column
:
Lib
.
ColumnMetadata
;
filter
?:
Lib
.
FilterClause
;
}
function
setup
({
query
,
stageIndex
,
column
,
filter
}:
SetupOpts
)
{
const
onChange
=
jest
.
fn
();
const
onInput
=
jest
.
fn
();
renderWithProviders
(
<
DateFilterEditor
query
=
{
query
}
stageIndex
=
{
stageIndex
}
column
=
{
column
}
filter
=
{
filter
}
isSearching
=
{
false
}
onChange
=
{
onChange
}
onInput
=
{
onInput
}
/>,
);
const
getNextFilterName
=
()
=>
{
const
[
nextFilter
]
=
onChange
.
mock
.
lastCall
;
return
nextFilter
?
Lib
.
displayInfo
(
query
,
stageIndex
,
nextFilter
).
displayName
:
null
;
};
return
{
onChange
,
onInput
,
getNextFilterName
};
}
describe
(
"
DateFilterEditor
"
,
()
=>
{
const
defaultQuery
=
createQuery
();
const
stageIndex
=
0
;
const
availableColumns
=
Lib
.
filterableColumns
(
defaultQuery
,
stageIndex
);
const
findColumn
=
columnFinder
(
defaultQuery
,
availableColumns
);
const
column
=
findColumn
(
"
ORDERS
"
,
"
CREATED_AT
"
);
describe
(
"
new filter
"
,
()
=>
{
it
(
"
should add a relative date filter from a shortcut
"
,
()
=>
{
const
{
getNextFilterName
}
=
setup
({
query
:
defaultQuery
,
stageIndex
,
column
,
});
userEvent
.
click
(
screen
.
getByText
(
"
Last month
"
));
expect
(
getNextFilterName
()).
toBe
(
"
Created At is in the previous month
"
);
});
it
(
"
should remove a relative date filter from a shortcut
"
,
()
=>
{
const
{
query
,
filter
}
=
createQueryWithFilter
(
defaultQuery
,
stageIndex
,
Lib
.
relativeDateFilterClause
({
column
,
value
:
"
current
"
,
bucket
:
"
day
"
,
offsetValue
:
null
,
offsetBucket
:
null
,
options
:
{},
}),
);
const
{
getNextFilterName
}
=
setup
({
query
,
stageIndex
,
column
,
filter
,
});
const
button
=
screen
.
getByRole
(
"
button
"
,
{
name
:
"
Today
"
});
expect
(
button
).
toHaveAttribute
(
"
aria-selected
"
,
"
true
"
);
userEvent
.
click
(
button
);
expect
(
getNextFilterName
()).
toBeNull
();
});
it
(
"
should add a relative date filter
"
,
async
()
=>
{
const
{
getNextFilterName
}
=
setup
({
query
:
defaultQuery
,
stageIndex
,
column
,
});
userEvent
.
click
(
screen
.
getByLabelText
(
"
More options
"
));
userEvent
.
click
(
await
screen
.
findByText
(
"
Last 30 days
"
));
expect
(
getNextFilterName
()).
toBe
(
"
Created At is in the previous 30 days
"
);
});
it
(
"
should remove a relative date filter
"
,
async
()
=>
{
const
{
query
,
filter
}
=
createQueryWithFilter
(
defaultQuery
,
stageIndex
,
Lib
.
relativeDateFilterClause
({
column
,
value
:
-
30
,
bucket
:
"
day
"
,
offsetValue
:
null
,
offsetBucket
:
null
,
options
:
{},
}),
);
const
{
getNextFilterName
}
=
setup
({
query
,
stageIndex
,
column
,
filter
,
});
expect
(
screen
.
getByText
(
"
Previous 30 Days
"
)).
toBeInTheDocument
();
userEvent
.
click
(
screen
.
getByLabelText
(
"
Clear
"
));
expect
(
getNextFilterName
()).
toBe
(
null
);
});
it
(
"
should add a specific date filter
"
,
async
()
=>
{
const
{
getNextFilterName
}
=
setup
({
query
:
defaultQuery
,
stageIndex
,
column
,
});
userEvent
.
click
(
screen
.
getByLabelText
(
"
More options
"
));
userEvent
.
click
(
await
screen
.
findByText
(
"
Specific dates…
"
));
userEvent
.
click
(
screen
.
getByText
(
"
After
"
));
userEvent
.
clear
(
screen
.
getByLabelText
(
"
Date
"
));
userEvent
.
type
(
screen
.
getByLabelText
(
"
Date
"
),
"
Feb 15, 2020
"
);
userEvent
.
click
(
screen
.
getByText
(
"
Add filter
"
));
expect
(
getNextFilterName
()).
toBe
(
"
Created At is after Feb 15, 2020
"
);
});
it
(
"
should remove a specific date filter
"
,
async
()
=>
{
const
{
query
,
filter
}
=
createQueryWithFilter
(
defaultQuery
,
stageIndex
,
Lib
.
specificDateFilterClause
(
defaultQuery
,
stageIndex
,
{
operator
:
"
=
"
,
column
,
values
:
[
new
Date
(
2020
,
1
,
15
)],
}),
);
const
{
getNextFilterName
}
=
setup
({
query
,
stageIndex
,
column
,
filter
,
});
expect
(
screen
.
getByText
(
"
Feb 15, 2020
"
)).
toBeInTheDocument
();
userEvent
.
click
(
screen
.
getByLabelText
(
"
Clear
"
));
expect
(
getNextFilterName
()).
toBe
(
null
);
});
it
(
"
should add an exclude date filter
"
,
async
()
=>
{
const
{
getNextFilterName
}
=
setup
({
query
:
defaultQuery
,
stageIndex
,
column
,
});
userEvent
.
click
(
screen
.
getByLabelText
(
"
More options
"
));
userEvent
.
click
(
await
screen
.
findByText
(
"
Exclude…
"
));
userEvent
.
click
(
screen
.
getByText
(
"
Hours of the day…
"
));
userEvent
.
click
(
screen
.
getByText
(
"
5 PM
"
));
userEvent
.
click
(
screen
.
getByText
(
"
Add filter
"
));
expect
(
getNextFilterName
()).
toBe
(
"
Created At excludes the hour of 5 PM
"
);
});
it
(
"
should remove an exclude date filter
"
,
async
()
=>
{
const
{
query
,
filter
}
=
createQueryWithFilter
(
defaultQuery
,
stageIndex
,
Lib
.
excludeDateFilterClause
(
defaultQuery
,
stageIndex
,
{
operator
:
"
!=
"
,
column
,
values
:
[
17
],
bucket
:
"
hour-of-day
"
,
}),
);
const
{
getNextFilterName
}
=
setup
({
query
,
stageIndex
,
column
,
filter
,
});
expect
(
screen
.
getByText
(
"
Created At excludes the hour of 5 PM
"
),
).
toBeInTheDocument
();
userEvent
.
click
(
screen
.
getByLabelText
(
"
Clear
"
));
expect
(
getNextFilterName
()).
toBe
(
null
);
});
});
});
function
createQueryWithFilter
(
initialQuery
:
Lib
.
Query
,
stageIndex
:
number
,
clause
:
Lib
.
ExpressionClause
|
Lib
.
SegmentMetadata
,
)
{
const
query
=
Lib
.
filter
(
initialQuery
,
stageIndex
,
clause
);
const
[
filter
]
=
Lib
.
filters
(
query
,
stageIndex
);
return
{
query
,
filter
};
}
This diff is collapsed.
Click to expand it.
Preview
0%
Loading
Try again
or
attach a new file
.
Cancel
You are about to add
0
people
to the discussion. Proceed with caution.
Finish editing this message first!
Save comment
Cancel
Please
register
or
sign in
to comment