Skip to content
Snippets Groups Projects
Commit ca53139d authored by Atte Keinänen's avatar Atte Keinänen
Browse files

Pass metadata to getQuestionUrl in FieldDetail

parent cfcf4f2e
No related branches found
No related tags found
No related merge requests found
......@@ -36,7 +36,7 @@ import * as metadataActions from 'metabase/redux/metadata';
import * as actions from 'metabase/reference/reference';
const interestingQuestions = (database, table, field) => {
const interestingQuestions = (database, table, field, metadata) => {
return [
{
text: `Number of ${table.display_name} grouped by ${field.display_name}`,
......@@ -46,7 +46,8 @@ const interestingQuestions = (database, table, field) => {
tableId: table.id,
fieldId: field.id,
getCount: true,
visualization: 'bar'
visualization: 'bar',
metadata
})
},
{
......@@ -57,7 +58,8 @@ const interestingQuestions = (database, table, field) => {
tableId: table.id,
fieldId: field.id,
getCount: true,
visualization: 'pie'
visualization: 'pie',
metadata
})
},
{
......@@ -66,7 +68,8 @@ const interestingQuestions = (database, table, field) => {
link: getQuestionUrl({
dbId: database.id,
tableId: table.id,
fieldId: field.id
fieldId: field.id,
metadata
})
}
]
......@@ -128,6 +131,7 @@ export default class FieldDetail extends Component {
loading: PropTypes.bool,
loadingError: PropTypes.object,
submitting: PropTypes.bool,
metadata: PropTypes.object
};
render() {
......@@ -146,6 +150,7 @@ export default class FieldDetail extends Component {
handleSubmit,
resetForm,
submitting,
metadata
} = this.props;
const onSubmit = handleSubmit(async (fields) =>
......@@ -226,7 +231,7 @@ export default class FieldDetail extends Component {
</li>
{ !isEditing &&
{ !isEditing &&
<li className="relative">
<Detail
id="base_type"
......@@ -246,7 +251,16 @@ export default class FieldDetail extends Component {
</li>
{ !isEditing &&
<li className="relative">
<UsefulQuestions questions={interestingQuestions(this.props.database, this.props.table, this.props.field)} />
<UsefulQuestions
questions={
interestingQuestions(
this.props.database,
this.props.table,
this.props.field,
metadata
)
}
/>
</li>
}
......
......@@ -9,6 +9,7 @@ import FieldDetail from "metabase/reference/databases/FieldDetail.jsx"
import * as metadataActions from 'metabase/redux/metadata';
import * as actions from 'metabase/reference/reference';
import { getMetadata } from "metabase/selectors/metadata";
import {
getDatabase,
......@@ -23,7 +24,8 @@ const mapStateToProps = (state, props) => ({
table: getTable(state, props),
field: getField(state, props),
databaseId: getDatabaseId(state, props),
isEditing: getIsEditing(state, props)
isEditing: getIsEditing(state, props),
metadata: getMetadata(state, props)
});
const mapDispatchToProps = {
......@@ -40,7 +42,8 @@ export default class FieldDetailContainer extends Component {
databaseId: PropTypes.number.isRequired,
table: PropTypes.object.isRequired,
field: PropTypes.object.isRequired,
isEditing: PropTypes.bool
isEditing: PropTypes.bool,
metadata: PropTypes.object
};
async fetchContainerData(){
......
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Finish editing this message first!
Please register or to comment