Revert graph settings sync change (#44535)

* Skip repro for 10493

* Add repro for 44532

* Remove `ensureMetricsAndDimensions`

e2e/test/scenarios/question-reproductions/reproductions-3.cy.spec.js

@@ -30,6 +30,7 @@ import {
   echartsContainer,
   newButton,
   appBar,
+  openProductsTable,
 } from "e2e/support/helpers";
 
 const { ORDERS, ORDERS_ID, PRODUCTS } = SAMPLE_DATABASE;
@@ -636,7 +637,7 @@ describe("issue 42957", () => {
   });
 });
 
-describe("issue 10493", () => {
+describe.skip("issue 10493", () => {
   beforeEach(() => {
     restore();
     cy.intercept("POST", "/api/dataset").as("dataset");
@@ -776,3 +777,87 @@ describe("issue 44415", () => {
     });
   });
 });
+
+describe("issue 44532", () => {
+  beforeEach(() => {
+    restore();
+    cy.signInAsAdmin();
+    openProductsTable();
+  });
+
+  it("should update chart metrics and dimensions with each added breakout (metabase #44532)", () => {
+    summarize();
+
+    rightSidebar()
+      .findByRole("listitem", { name: "Category" })
+      .button("Add dimension")
+      .click();
+    cy.wait("@dataset");
+
+    echartsContainer().within(() => {
+      cy.findByText("Count").should("exist"); // y-axis
+      cy.findByText("Category").should("exist"); // x-axis
+
+      // x-axis values
+      cy.findByText("Doohickey").should("exist");
+      cy.findByText("Gadget").should("exist");
+      cy.findByText("Gizmo").should("exist");
+      cy.findByText("Widget").should("exist");
+    });
+
+    rightSidebar()
+      .findByRole("listitem", { name: "Created At" })
+      .button("Add dimension")
+      .click();
+    cy.wait("@dataset");
+
+    cy.findByLabelText("Legend").within(() => {
+      cy.findByText("Doohickey").should("exist");
+      cy.findByText("Gadget").should("exist");
+      cy.findByText("Gizmo").should("exist");
+      cy.findByText("Widget").should("exist");
+    });
+
+    echartsContainer().within(() => {
+      cy.findByText("Count").should("exist"); // y-axis
+      cy.findByText("Created At").should("exist"); // x-axis
+
+      // x-axis values
+      cy.findByText("January 2023").should("exist");
+      cy.findByText("January 2024").should("exist");
+      cy.findByText("January 2025").should("exist");
+
+      // previous x-axis values
+      cy.findByText("Doohickey").should("not.exist");
+      cy.findByText("Gadget").should("not.exist");
+      cy.findByText("Gizmo").should("not.exist");
+      cy.findByText("Widget").should("not.exist");
+    });
+
+    rightSidebar().button("Done").click();
+    cy.wait("@dataset");
+
+    cy.findByLabelText("Legend").within(() => {
+      cy.findByText("Doohickey").should("exist");
+      cy.findByText("Gadget").should("exist");
+      cy.findByText("Gizmo").should("exist");
+      cy.findByText("Widget").should("exist");
+    });
+
+    echartsContainer().within(() => {
+      cy.findByText("Count").should("exist"); // y-axis
+      cy.findByText("Created At").should("exist"); // x-axis
+
+      // x-axis values
+      cy.findByText("January 2023").should("exist");
+      cy.findByText("January 2024").should("exist");
+      cy.findByText("January 2025").should("exist");
+
+      // previous x-axis values
+      cy.findByText("Doohickey").should("not.exist");
+      cy.findByText("Gadget").should("not.exist");
+      cy.findByText("Gizmo").should("not.exist");
+      cy.findByText("Widget").should("not.exist");
+    });
+  });
+});

frontend/src/metabase/visualizations/index.ts

@@ -128,15 +128,6 @@ export function getDefaultSize(display: string) {
   return visualization?.defaultSize;
 }
 
-export function hasGraphDataSettings(display: string) {
-  const visualization = visualizations.get(display);
-  const settingDefinitions = visualization?.settings ?? {};
-  return (
-    "graph.dimensions" in settingDefinitions &&
-    "graph.metrics" in settingDefinitions
-  );
-}
-
 // removes columns with `remapped_from` property and adds a `remapping` to the appropriate column
 export const extractRemappedColumns = (data: DatasetData) => {
   const cols: RemappingHydratedDatasetColumn[] = data.cols.map(col => ({

frontend/src/metabase/visualizations/lib/sync-settings.ts

-import { isNotNull } from "metabase/lib/types";
-import {
-  getMaxDimensionsSupported,
-  getMaxMetricsSupported,
-  hasGraphDataSettings,
-} from "metabase/visualizations";
 import {
   findColumnIndexesForColumnSettings,
   findColumnSettingIndexesForColumns,
@@ -15,8 +9,6 @@ import type {
   VisualizationSettings,
 } from "metabase-types/api";
 
-import { getSingleSeriesDimensionsAndMetrics } from "./utils";
-
 export function syncVizSettingsWithSeries(
   settings: VisualizationSettings,
   _series?: Series | null,
@@ -36,71 +28,12 @@ export function syncVizSettingsWithSeries(
         series,
         previousSeries,
       );
-
-      if (hasGraphDataSettings(series.card.display)) {
-        newSettings = ensureMetricsAndDimensions(
-          newSettings,
-          series,
-          previousSeries,
-        );
-      }
     }
   }
 
   return newSettings;
 }
 
-function ensureMetricsAndDimensions(
-  settings: VisualizationSettings,
-  series: SingleSeries,
-  previousSeries: SingleSeries,
-) {
-  const hasExplicitGraphDataSettings =
-    "graph.dimensions" in settings || "graph.metrics" in settings;
-
-  if (hasExplicitGraphDataSettings) {
-    return settings;
-  }
-
-  const nextSettings = { ...settings };
-
-  const availableColumnNames = series.data.cols.map(col => col.name);
-  const maxDimensions = getMaxDimensionsSupported(series.card.display);
-  const maxMetrics = getMaxMetricsSupported(series.card.display);
-
-  const { dimensions: currentDimensions, metrics: currentMetrics } =
-    getSingleSeriesDimensionsAndMetrics(series, maxDimensions, maxMetrics);
-  const { dimensions: previousDimensions, metrics: previousMetrics } =
-    getSingleSeriesDimensionsAndMetrics(
-      previousSeries,
-      maxDimensions,
-      maxMetrics,
-    );
-
-  const dimensions =
-    currentDimensions.filter(isNotNull).length > 0
-      ? currentDimensions
-      : previousDimensions.filter((columnName: string) =>
-          availableColumnNames.includes(columnName),
-        );
-
-  const metrics =
-    currentMetrics.filter(isNotNull).length > 0
-      ? currentMetrics
-      : previousMetrics.filter((columnName: string) =>
-          availableColumnNames.includes(columnName),
-        );
-
-  if (dimensions.length > 0) {
-    nextSettings["graph.dimensions"] = dimensions;
-  }
-  if (metrics.length > 0) {
-    nextSettings["graph.metrics"] = metrics;
-  }
-
-  return nextSettings;
-}
-
 function syncTableColumnSettings(
   settings: VisualizationSettings,
   { data }: SingleSeries,